src/x87/full-codegen-x87.cc - Issue 669823002: X87: vector-based ICs did not update type feedback counts correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x87/full-codegen-x87.cc

Issue 669823002: X87: vector-based ICs did not update type feedback counts correctly. (Closed) Base URL: https://chromium.googlesource.com/external/v8.git@bleeding_edge

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x87/full-codegen-x87.cc

diff --git a/src/x87/full-codegen-x87.cc b/src/x87/full-codegen-x87.cc

index 8ae718f1609c9bdda157cb466bc0f5e3efe85f3e..746110a458d77f717ef118fba4b304090bfc0909 100644

--- a/src/x87/full-codegen-x87.cc

+++ b/src/x87/full-codegen-x87.cc

@@ -1106,7 +1106,8 @@ void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {

// No need for a write barrier, we are storing a Smi in the feedback vector.

__ LoadHeapObject(ebx, FeedbackVector());

- __ mov(FieldOperand(ebx, FixedArray::OffsetOfElementAt(slot.ToInt())),

+ int vector_index = FeedbackVector()->GetIndex(slot);

+ __ mov(FieldOperand(ebx, FixedArray::OffsetOfElementAt(vector_index)),

Immediate(TypeFeedbackVector::MegamorphicSentinel(isolate())));

__ mov(ebx, Immediate(Smi::FromInt(1))); // Smi indicates slow check

« no previous file with comments | « src/x87/code-stubs-x87.cc ('k') | src/x87/lithium-codegen-x87.cc » ('j') | no next file with comments »