Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Side by Side Diff: src/x87/full-codegen-x87.cc

Issue 669823002: X87: vector-based ICs did not update type feedback counts correctly. (Closed) Base URL: https://chromium.googlesource.com/external/v8.git@bleeding_edge
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x87/code-stubs-x87.cc ('k') | src/x87/lithium-codegen-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X87 7 #if V8_TARGET_ARCH_X87
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1088 matching lines...) Expand 10 before | Expand all | Expand 10 after
1099 __ bind(&no_descriptors); 1099 __ bind(&no_descriptors);
1100 __ add(esp, Immediate(kPointerSize)); 1100 __ add(esp, Immediate(kPointerSize));
1101 __ jmp(&exit); 1101 __ jmp(&exit);
1102 1102
1103 // We got a fixed array in register eax. Iterate through that. 1103 // We got a fixed array in register eax. Iterate through that.
1104 Label non_proxy; 1104 Label non_proxy;
1105 __ bind(&fixed_array); 1105 __ bind(&fixed_array);
1106 1106
1107 // No need for a write barrier, we are storing a Smi in the feedback vector. 1107 // No need for a write barrier, we are storing a Smi in the feedback vector.
1108 __ LoadHeapObject(ebx, FeedbackVector()); 1108 __ LoadHeapObject(ebx, FeedbackVector());
1109 __ mov(FieldOperand(ebx, FixedArray::OffsetOfElementAt(slot.ToInt())), 1109 int vector_index = FeedbackVector()->GetIndex(slot);
1110 __ mov(FieldOperand(ebx, FixedArray::OffsetOfElementAt(vector_index)),
1110 Immediate(TypeFeedbackVector::MegamorphicSentinel(isolate()))); 1111 Immediate(TypeFeedbackVector::MegamorphicSentinel(isolate())));
1111 1112
1112 __ mov(ebx, Immediate(Smi::FromInt(1))); // Smi indicates slow check 1113 __ mov(ebx, Immediate(Smi::FromInt(1))); // Smi indicates slow check
1113 __ mov(ecx, Operand(esp, 0 * kPointerSize)); // Get enumerated object 1114 __ mov(ecx, Operand(esp, 0 * kPointerSize)); // Get enumerated object
1114 STATIC_ASSERT(FIRST_JS_PROXY_TYPE == FIRST_SPEC_OBJECT_TYPE); 1115 STATIC_ASSERT(FIRST_JS_PROXY_TYPE == FIRST_SPEC_OBJECT_TYPE);
1115 __ CmpObjectType(ecx, LAST_JS_PROXY_TYPE, ecx); 1116 __ CmpObjectType(ecx, LAST_JS_PROXY_TYPE, ecx);
1116 __ j(above, &non_proxy); 1117 __ j(above, &non_proxy);
1117 __ Move(ebx, Immediate(Smi::FromInt(0))); // Zero indicates proxy 1118 __ Move(ebx, Immediate(Smi::FromInt(0))); // Zero indicates proxy
1118 __ bind(&non_proxy); 1119 __ bind(&non_proxy);
1119 __ push(ebx); // Smi 1120 __ push(ebx); // Smi
(...skipping 4009 matching lines...) Expand 10 before | Expand all | Expand 10 after
5129 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 5130 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
5130 Assembler::target_address_at(call_target_address, 5131 Assembler::target_address_at(call_target_address,
5131 unoptimized_code)); 5132 unoptimized_code));
5132 return OSR_AFTER_STACK_CHECK; 5133 return OSR_AFTER_STACK_CHECK;
5133 } 5134 }
5134 5135
5135 5136
5136 } } // namespace v8::internal 5137 } } // namespace v8::internal
5137 5138
5138 #endif // V8_TARGET_ARCH_X87 5139 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/x87/code-stubs-x87.cc ('k') | src/x87/lithium-codegen-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698