Source/core/page/EventHandler.cpp - Issue 669803002: Optimize for horizontal writing mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/EventHandler.cpp

Issue 669803002: Optimize for horizontal writing mode (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Changed RenderView to use hasFlippedBlocksWritingMode Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/EventHandler.cpp

diff --git a/Source/core/page/EventHandler.cpp b/Source/core/page/EventHandler.cpp

index b3f8ac4a84d8b45acb39ffb94f57df6703673535..f7d9fdb5ad17cf77570a667739afbdc3a8bc63af 100644

--- a/Source/core/page/EventHandler.cpp

+++ b/Source/core/page/EventHandler.cpp

@@ -903,7 +903,7 @@ bool EventHandler::scroll(ScrollDirection direction, ScrollGranularity granulari

RenderBox* curBox = node->renderer()->enclosingBox();

while (curBox && !curBox->isRenderView()) {

ScrollDirection physicalDirection = toPhysicalDirection(

- direction, curBox->isHorizontalWritingMode(), curBox->style()->isFlippedBlocksWritingMode());

+ direction, curBox->isHorizontalWritingMode(), curBox->style()->slowIsFlippedBlocksWritingMode());

pdr. 2014/10/22 18:41:58 Nearly all of these should be able to use the fast

leviw_travelin_and_unemployed 2014/10/22 18:50:27 I'm fine with doing it in a follow-up as long as w

// If we're at the stopNode, we should try to scroll it but we shouldn't bubble past it

bool shouldStopBubbling = stopNode && *stopNode && curBox->node() == *stopNode;

« no previous file with comments | « Source/core/frame/FrameView.cpp ('k') | Source/core/page/PrintContext.cpp » ('j') | no next file with comments »