Source/core/page/PrintContext.cpp - Issue 669803002: Optimize for horizontal writing mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/PrintContext.cpp

Issue 669803002: Optimize for horizontal writing mode (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Changed RenderView to use hasFlippedBlocksWritingMode Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/PrintContext.cpp

diff --git a/Source/core/page/PrintContext.cpp b/Source/core/page/PrintContext.cpp

index 34da6e09752c82a9010d74d5c3db871c7da89033..277f0ebb6a362c4020f93fe76b3cde8607c99c18 100644

--- a/Source/core/page/PrintContext.cpp

+++ b/Source/core/page/PrintContext.cpp

@@ -113,7 +113,7 @@ void PrintContext::computePageRectsWithPageSizeInternal(const FloatSize& pageSiz

int blockDirectionStart;

int blockDirectionEnd;

if (isHorizontal) {

- if (view->style()->isFlippedBlocksWritingMode()) {

+ if (view->style()->slowIsFlippedBlocksWritingMode()) {

blockDirectionStart = docRect.maxY();

blockDirectionEnd = docRect.y();

} else {

@@ -123,7 +123,7 @@ void PrintContext::computePageRectsWithPageSizeInternal(const FloatSize& pageSiz

inlineDirectionStart = view->style()->isLeftToRightDirection() ? docRect.x() : docRect.maxX();

inlineDirectionEnd = view->style()->isLeftToRightDirection() ? docRect.maxX() : docRect.x();

} else {

- if (view->style()->isFlippedBlocksWritingMode()) {

+ if (view->style()->slowIsFlippedBlocksWritingMode()) {

blockDirectionStart = docRect.maxX();

blockDirectionEnd = docRect.x();

} else {