Source/core/rendering/RenderFlowThread.cpp - Issue 669803002: Optimize for horizontal writing mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderFlowThread.cpp

Issue 669803002: Optimize for horizontal writing mode (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: w compile fix Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderFlowThread.cpp

diff --git a/Source/core/rendering/RenderFlowThread.cpp b/Source/core/rendering/RenderFlowThread.cpp

index 0d69b0da6dff7a9d0ab86429c434897b16c8890c..bbb67eb16f960af05d02491b75793bfc3a7f16d1 100644

--- a/Source/core/rendering/RenderFlowThread.cpp

+++ b/Source/core/rendering/RenderFlowThread.cpp

@@ -353,7 +353,7 @@ LayoutUnit RenderFlowThread::offsetFromLogicalTopOfFirstRegion(const RenderBlock

if (containerBlock->style()->writingMode() != currentBlock->style()->writingMode()) {

// We have to put the block rect in container coordinates

// and we have to take into account both the container and current block flipping modes

- if (containerBlock->style()->isFlippedBlocksWritingMode()) {

+ if (containerBlock->style()->slowIsFlippedBlocksWritingMode()) {

if (containerBlock->isHorizontalWritingMode())

blockRect.setY(currentBlock->height() - blockRect.maxY());

else