Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issue 669723003: [Android] Move setting of contentDescription out from content/ layer. (Closed)

Created:
6 years, 2 months ago by benm (inactive)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, jam, David Trainor- moved to gerrit, avayvod+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Move setting of contentDescription out from content/ layer. Chrome for Android now sets the content description for it's ContentView's and we do not force (and potentially override) content descriptions set on container views set by other content/ embedders (e.g. the Android WebView). BUG=422284 Committed: https://crrev.com/cff7ec22cc8c1c10335db47e52e98ba81d8986a4 Cr-Commit-Position: refs/heads/master@{#300515}

Patch Set 1 #

Patch Set 2 : Fix up ps1 #

Patch Set 3 : update the content grd #

Total comments: 2

Patch Set 4 : fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 1 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +0 lines, -8 lines 0 comments Download
M content/public/android/java/strings/android_content_strings.grd View 1 2 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (9 generated)
benm (inactive)
ptal
6 years, 2 months ago (2014-10-21 12:23:34 UTC) #2
benm (inactive)
6 years, 2 months ago (2014-10-21 12:29:03 UTC) #4
dmazzoni
lgtm
6 years, 2 months ago (2014-10-21 15:21:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669723003/20001
6 years, 2 months ago (2014-10-21 15:22:49 UTC) #7
benm (inactive)
On 2014/10/21 15:22:49, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 2 months ago (2014-10-21 15:24:40 UTC) #9
jdduke (slow)
In which WebView is not a Web View... got it... :) lgtm.
6 years, 2 months ago (2014-10-21 15:25:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669723003/40001
6 years, 2 months ago (2014-10-21 15:30:00 UTC) #12
benm (inactive)
+miguelg for chrom/android OWNERS
6 years, 2 months ago (2014-10-21 15:37:49 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/18968)
6 years, 2 months ago (2014-10-21 15:37:49 UTC) #16
Miguel Garcia
lgtm % nit https://codereview.chromium.org/669723003/diff/40001/chrome/android/java/strings/android_chrome_strings.grd File chrome/android/java/strings/android_chrome_strings.grd (right): https://codereview.chromium.org/669723003/diff/40001/chrome/android/java/strings/android_chrome_strings.grd#newcode265 chrome/android/java/strings/android_chrome_strings.grd:265: <message name="IDS_ACCESSIBILITY_CONTENT_VIEW" desc="Content description for the ...
6 years, 2 months ago (2014-10-21 15:55:47 UTC) #18
benm (inactive)
https://codereview.chromium.org/669723003/diff/40001/chrome/android/java/strings/android_chrome_strings.grd File chrome/android/java/strings/android_chrome_strings.grd (right): https://codereview.chromium.org/669723003/diff/40001/chrome/android/java/strings/android_chrome_strings.grd#newcode265 chrome/android/java/strings/android_chrome_strings.grd:265: <message name="IDS_ACCESSIBILITY_CONTENT_VIEW" desc="Content description for the content view that ...
6 years, 2 months ago (2014-10-21 16:01:58 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669723003/60001
6 years, 2 months ago (2014-10-21 16:02:24 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 2 months ago (2014-10-21 17:45:44 UTC) #22
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 17:46:34 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/cff7ec22cc8c1c10335db47e52e98ba81d8986a4
Cr-Commit-Position: refs/heads/master@{#300515}

Powered by Google App Engine
This is Rietveld 408576698