content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 669723003: [Android] Move setting of contentDescription out from content/ layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 669723003: [Android] Move setting of contentDescription out from content/ layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix nit Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/strings/android_chrome_strings.grd ('k') | content/public/android/java/strings/android_content_strings.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index 2f8857816be0057ec75099785181429d7c083b8b..f3a1da8075085b2ef5df4884041e005c68163f85 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -675,14 +675,6 @@ public class ContentViewCore

mContainerView = containerView;

mPositionObserver = new ViewPositionObserver(mContainerView);

- String contentDescription = "Web View";

- if (R.string.accessibility_content_view == 0) {

- Log.w(TAG, "Setting contentDescription to 'Web View' as no value was specified.");

- } else {

- contentDescription = mContext.getResources().getString(

- R.string.accessibility_content_view);

- }

- mContainerView.setContentDescription(contentDescription);

mContainerView.setWillNotDraw(false);

mContainerView.setClickable(true);

TraceEvent.end();