Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: commit-queue/verification/try_job_on_rietveld.py

Issue 66963004: CQ: don't give up on update and clobber build failures (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: commit-queue/verification/try_job_on_rietveld.py
===================================================================
--- commit-queue/verification/try_job_on_rietveld.py (revision 234601)
+++ commit-queue/verification/try_job_on_rietveld.py (working copy)
@@ -448,24 +448,6 @@
(job.builder, ', '.join(missing_tests), url))
logging.info(self.error_message)
return True
- elif 'update' in job.steps_failed:
- self.error_message = (
- 'Step "update" is always a major failure.\n'
- 'Look at the try server FAQ for more details.\n%s' % url)
- logging.info(self.error_message)
- return True
- elif 'compile' in job.steps_failed and job.clobber:
- self.error_message = (
- 'Sorry for I got bad news for ya.\n'
- 'Compile failed with a clobber build on %s.\n'
- '%s\n'
- 'Your code is likely broken or HEAD is junk. Please ensure your\n'
- 'code is not broken then alert the build sheriffs.\n'
- 'Look at the try server FAQ for more details.') % (
- job.builder,
- url)
- logging.info(self.error_message)
- return True
return False
@model.immutable
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698