CQ: don't give up on update and clobber build failures

commit-queue/verification/try_job_on_rietveld.py

 # coding=utf8
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Sends patches to the Try server and reads back results.
 
 - RietveldTryJobs contains RietveldTryJob, one per try job on a builder.
 - TryRunnerRietveld uses Rietveld to signal and poll job results.
 """
 
@@ skipping 430 matching lines @@
     # Figure out steps that should be retried for this builder.
     missing_tests = self.tests_need_to_be_run(now).get(job.builder, [])
     if not missing_tests:
       return False
     if job.tries > 2:
       self.error_message = (
           'Retried try job too often on %s for step(s) %s\n%s' %
            (job.builder, ', '.join(missing_tests), url))
       logging.info(self.error_message)
       return True
-    elif 'update' in job.steps_failed:
-      self.error_message = (
-          'Step "update" is always a major failure.\n'
-          'Look at the try server FAQ for more details.\n%s' % url)
-      logging.info(self.error_message)
-      return True
-    elif 'compile' in job.steps_failed and job.clobber:
-      self.error_message = (
-          'Sorry for I got bad news for ya.\n'
-          'Compile failed with a clobber build on %s.\n'
-          '%s\n'
-          'Your code is likely broken or HEAD is junk. Please ensure your\n'
-          'code is not broken then alert the build sheriffs.\n'
-          'Look at the try server FAQ for more details.') % (
-              job.builder,
-              url)
-      logging.info(self.error_message)
-      return True
     return False
 
   @model.immutable
   def why_not(self):
     # Skipped or failed, nothing to do.
     if self.skipped or self.error_message:
       return None
     waiting = self.tests_waiting_for_result()
     if waiting:
       out = 'Waiting for the following jobs:\n'
@@ skipping 281 matching lines @@
         logging.warning(str(e))
         return False
       raise
     if handle:
       for updated_key in keys:
         job = jobs.try_jobs[updated_key]
         self._update_dashboard(pending, job, status)
         jobs.signal_as_failed_if_needed(job, self._build_status_url(job), now)
 
     return True