Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 669593002: Disabling flaky WebRtcAecDumpBrowserTest.TwoCallsWithAecDump on Win XP. (Closed)

Created:
6 years, 2 months ago by phoglund_chromium
Modified:
6 years, 2 months ago
Reviewers:
*perkj_chrome, *sky
CC:
chromium-reviews, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disabling flaky WebRtcAecDumpBrowserTest.TwoCallsWithAecDump on Win XP. BUG=425034 Committed: https://crrev.com/a2822d2f12db6e00d4d93a2316318a53f18531d6 Cr-Commit-Position: refs/heads/master@{#300437}

Patch Set 1 #

Patch Set 2 : Fixed silly compilation error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M content/browser/media/webrtc_aecdump_browsertest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/test/webrtc_content_browsertest_base.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/webrtc_content_browsertest_base.cc View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
phoglund_chromium
sky: WebRtcContentBrowserTest changes perkj: test changes
6 years, 2 months ago (2014-10-20 08:12:32 UTC) #3
perkj_chrome
On 2014/10/20 08:12:32, phoglund wrote: > sky: WebRtcContentBrowserTest changes > perkj: test changes isn't there ...
6 years, 2 months ago (2014-10-20 14:45:45 UTC) #4
phoglund_chromium
On 2014/10/20 14:45:45, perkj wrote: > On 2014/10/20 08:12:32, phoglund wrote: > > sky: WebRtcContentBrowserTest ...
6 years, 2 months ago (2014-10-20 14:48:12 UTC) #5
perkj_chrome
lgtm
6 years, 2 months ago (2014-10-20 15:43:13 UTC) #6
sky
LGTM
6 years, 2 months ago (2014-10-20 20:21:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669593002/20001
6 years, 2 months ago (2014-10-21 08:00:01 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-21 08:48:43 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 08:49:51 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a2822d2f12db6e00d4d93a2316318a53f18531d6
Cr-Commit-Position: refs/heads/master@{#300437}

Powered by Google App Engine
This is Rietveld 408576698