Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Side by Side Diff: content/browser/media/webrtc_aecdump_browsertest.cc

Issue 669593002: Disabling flaky WebRtcAecDumpBrowserTest.TwoCallsWithAecDump on Win XP. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed silly compilation error Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/test/webrtc_content_browsertest_base.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/process/process_handle.h" 5 #include "base/process/process_handle.h"
6 #include "base/strings/string_number_conversions.h" 6 #include "base/strings/string_number_conversions.h"
7 #include "base/strings/stringprintf.h" 7 #include "base/strings/stringprintf.h"
8 #include "content/browser/media/webrtc_internals.h" 8 #include "content/browser/media/webrtc_internals.h"
9 #include "content/browser/web_contents/web_contents_impl.h" 9 #include "content/browser/web_contents/web_contents_impl.h"
10 #include "content/public/test/browser_test_utils.h" 10 #include "content/public/test/browser_test_utils.h"
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 // Timing out on ARM linux bot: http://crbug.com/238490 161 // Timing out on ARM linux bot: http://crbug.com/238490
162 #define MAYBE_TwoCallsWithAecDump DISABLED_TwoCallsWithAecDump 162 #define MAYBE_TwoCallsWithAecDump DISABLED_TwoCallsWithAecDump
163 #elif defined(OS_ANDROID) && defined(ADDRESS_SANITIZER) 163 #elif defined(OS_ANDROID) && defined(ADDRESS_SANITIZER)
164 // Renderer crashes under Android ASAN: https://crbug.com/408496. 164 // Renderer crashes under Android ASAN: https://crbug.com/408496.
165 #define MAYBE_TwoCallsWithAecDump DISABLED_TwoCallsWithAecDump 165 #define MAYBE_TwoCallsWithAecDump DISABLED_TwoCallsWithAecDump
166 #else 166 #else
167 #define MAYBE_TwoCallsWithAecDump TwoCallsWithAecDump 167 #define MAYBE_TwoCallsWithAecDump TwoCallsWithAecDump
168 #endif 168 #endif
169 169
170 IN_PROC_BROWSER_TEST_F(WebRtcAecDumpBrowserTest, MAYBE_TwoCallsWithAecDump) { 170 IN_PROC_BROWSER_TEST_F(WebRtcAecDumpBrowserTest, MAYBE_TwoCallsWithAecDump) {
171 if (OnWinXp()) {
172 // http://crbug.com/425034.
173 LOG(INFO) << "Disabled on Win XP: skipping test...";
174 return;
175 }
171 if (!media::AudioManager::Get()->HasAudioOutputDevices()) { 176 if (!media::AudioManager::Get()->HasAudioOutputDevices()) {
172 LOG(INFO) << "Missing output devices: skipping test..."; 177 LOG(INFO) << "Missing output devices: skipping test...";
173 return; 178 return;
174 } 179 }
175 180
176 ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady()); 181 ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
177 182
178 // We must navigate somewhere first so that the render process is created. 183 // We must navigate somewhere first so that the render process is created.
179 NavigateToURL(shell(), GURL("")); 184 NavigateToURL(shell(), GURL(""));
180 185
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
219 EXPECT_TRUE(base::PathExists(unique_dump_file)); 224 EXPECT_TRUE(base::PathExists(unique_dump_file));
220 int64 file_size = 0; 225 int64 file_size = 0;
221 EXPECT_TRUE(base::GetFileSize(unique_dump_file, &file_size)); 226 EXPECT_TRUE(base::GetFileSize(unique_dump_file, &file_size));
222 EXPECT_GT(file_size, 0); 227 EXPECT_GT(file_size, 0);
223 228
224 base::DeleteFile(unique_dump_file, false); 229 base::DeleteFile(unique_dump_file, false);
225 } 230 }
226 } 231 }
227 232
228 } // namespace content 233 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | content/test/webrtc_content_browsertest_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698