Chromium Code Reviews

Issue 669393002: Merge 661693003 to M39: Avoid reporting 0 as input level when AudioProcessing zero out the audio da… (Closed)

Created:
6 years, 2 months ago by no longer working on chromium
Modified:
6 years, 2 months ago
Reviewers:
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2171
Project:
chromium
Visibility:
Public.

Description

Merge 661693003 to M39: Avoid reporting 0 as input level when AudioProcessing zero out the audio data Avoid reporting 0 as input level when AudioProcessing zero out the audio data. When the microphone volume is low, the pre-processed audio data contains energy, while the post-processed audio data has only 0, we report 0 as energy before this patch, which is wrong since the audio flow contains energy. This patch fix the problem by checking the energy of pre-processed data before reporting 0 as energy. TBR=tommi@chromium.org BUG=424149 TEST=1, use a USB headset. 2, set the microphone volume low, like below 50%. 3, join a hangout call. 4, open chrome://webrtc-internals, and look at the energy of input stream, constantly it is 0 there. Committed: https://chromium.googlesource.com/chromium/src/+/da6c91364a2c062353432e8138f6b472b24b558a

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+47 lines, -14 lines)
M content/renderer/media/media_stream_audio_level_calculator.h View 1 chunk +7 lines, -1 line 0 comments
M content/renderer/media/media_stream_audio_level_calculator.cc View 2 chunks +7 lines, -4 lines 0 comments
M content/renderer/media/webaudio_capturer_source.cc View 1 chunk +1 line, -1 line 0 comments
M content/renderer/media/webrtc/webrtc_local_audio_track_adapter_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments
M content/renderer/media/webrtc_audio_capturer.cc View 4 chunks +25 lines, -3 lines 0 comments
M content/renderer/media/webrtc_local_audio_track.h View 1 chunk +2 lines, -1 line 0 comments
M content/renderer/media/webrtc_local_audio_track.cc View 1 chunk +3 lines, -2 lines 0 comments

Messages

Total messages: 1 (0 generated)
no longer working on chromium
6 years, 2 months ago (2014-10-23 10:08:39 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
da6c91364a2c062353432e8138f6b472b24b558a (presubmit successful).

Powered by Google App Engine