Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 669243003: Add utils to better quantize grayscale values to three bit indices while (Closed)

Created:
6 years, 2 months ago by pavelk
Modified:
6 years, 2 months ago
Reviewers:
hcm, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add utils to better quantize grayscale values to three bit indices while compressing coverage masks. Signed-off-by: Pavel Krajcevski <pavel@cs.unc.edu>; BUG=skia: Committed: https://skia.googlesource.com/skia/+/47eedcc848e7712aea9607fd489abdc70bc8bcfd

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit + Add to AUTHORS #

Patch Set 3 : Add comment #

Patch Set 4 : Update tests to reflect new qunatization method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -3 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M gyp/utils.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M src/utils/SkTextureCompressor_LATC.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/utils/SkTextureCompressor_R11EAC.cpp View 2 chunks +2 lines, -1 line 0 comments Download
A src/utils/SkTextureCompressor_Utils.h View 1 2 1 chunk +68 lines, -0 lines 0 comments Download
M tests/TextureCompressionTest.cpp View 1 2 3 1 chunk +33 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
pavelk
6 years, 2 months ago (2014-10-22 21:31:27 UTC) #2
robertphillips
looks good to me (modulo a nit). Does this slow things down at all? Adding ...
6 years, 2 months ago (2014-10-23 12:10:20 UTC) #4
hcm
On 2014/10/23 12:10:20, robertphillips wrote: > looks good to me (modulo a nit). Does this ...
6 years, 2 months ago (2014-10-23 13:26:02 UTC) #5
pavelk
I've added my name to the AUTHORS file. Yes, it does slow things down a ...
6 years, 2 months ago (2014-10-23 16:05:03 UTC) #6
robertphillips
lgtm. I have verified that Pavel has signed the CLA.
6 years, 2 months ago (2014-10-23 16:11:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669243003/40001
6 years, 2 months ago (2014-10-23 16:12:33 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/187)
6 years, 2 months ago (2014-10-23 16:28:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669243003/60001
6 years, 2 months ago (2014-10-23 20:10:45 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 20:18:54 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 47eedcc848e7712aea9607fd489abdc70bc8bcfd

Powered by Google App Engine
This is Rietveld 408576698