Removing unwanted targets from all for the Athena build target

Removing unwanted targets from all for the Athena build target

BUG=410400
TEST=-

Committed: https://crrev.com/4d2961fdfbb9c1bfdac9e9d77c3d3a69ba0773db
Cr-Commit-Position: refs/heads/master@{#300885}

[Mr4D (OOO till 08-26), 2014-10-22 16:53:33]

skuhne@chromium.org changed reviewers:
+ sky@chromium.org

[Mr4D (OOO till 08-26), 2014-10-22 16:53:34]

I think this should be it (removing unnecessary chrome build targets for
Athena).


Please have a look!

[sky, 2014-10-22 17:24:12]

https://codereview.chromium.org/669203002/diff/1/build/all.gyp
File build/all.gyp (right):

https://codereview.chromium.org/669203002/diff/1/build/all.gyp#newcode148
build/all.gyp:148: # Athena has to depend temporarily on Chrome. Since most
tests do
Your statement is a bit confusing. I think you mean something like, "Athena
temporarily depends upon a subset of chrome."

https://codereview.chromium.org/669203002/diff/1/build/all.gyp#newcode154
build/all.gyp:154: }],
Typically we use an else for this. See line 224 for the else syntax.

https://codereview.chromium.org/669203002/diff/1/build/all.gyp#newcode297
build/all.gyp:297: 'target_name': 'chromium_builder_tests',
Are you sure you don't end up pulling in this target too? Did you try an all
build locally? Make sure you do lowercase all and not All.

[Mr4D (OOO till 08-26), 2014-10-22 23:39:31]

Please have another look!

https://codereview.chromium.org/669203002/diff/1/build/all.gyp
File build/all.gyp (right):

https://codereview.chromium.org/669203002/diff/1/build/all.gyp#newcode148
build/all.gyp:148: # Athena has to depend temporarily on Chrome. Since most
tests do
On 2014/10/22 17:24:11, sky wrote:
> Your statement is a bit confusing. I think you mean something like, "Athena
> temporarily depends upon a subset of chrome."

Done.

https://codereview.chromium.org/669203002/diff/1/build/all.gyp#newcode154
build/all.gyp:154: }],
Wohow. that "syntax" is easy to miss. Done!

https://codereview.chromium.org/669203002/diff/1/build/all.gyp#newcode297
build/all.gyp:297: 'target_name': 'chromium_builder_tests',
In deed. Needed to do several rounds bout have found now all dependencies.

[sky, 2014-10-22 23:42:33]

I'm surprised you want as much as you do, but ok. LGTM

[Mr4D (OOO till 08-26), 2014-10-22 23:55:55]

The CQ bit was checked by skuhne@chromium.org

[commit-bot: I haz the power, 2014-10-22 23:56:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/669203002/20001

[commit-bot: I haz the power, 2014-10-23 00:02:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-23 00:02:31]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/72310)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  linux_chromium_asan_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32 on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)

[Mr4D (OOO till 08-26), 2014-10-23 00:08:22]

The CQ bit was checked by skuhne@chromium.org

[commit-bot: I haz the power, 2014-10-23 00:10:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/669203002/40001

[commit-bot: I haz the power, 2014-10-23 00:17:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-23 00:17:26]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/72316)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/77236)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  linux_chromium_asan_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32 on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)

[Mr4D (OOO till 08-26), 2014-10-23 00:44:16]

The CQ bit was checked by skuhne@chromium.org

[commit-bot: I haz the power, 2014-10-23 00:45:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/669203002/60001

[commit-bot: I haz the power, 2014-10-23 00:55:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-23 00:55:25]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Mr4D (OOO till 08-26), 2014-10-23 01:05:09]

The CQ bit was checked by skuhne@chromium.org

[commit-bot: I haz the power, 2014-10-23 01:06:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/669203002/60001

[commit-bot: I haz the power, 2014-10-23 01:16:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-23 01:16:28]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Mr4D (OOO till 08-26), 2014-10-23 02:06:32]

The CQ bit was checked by skuhne@chromium.org

[commit-bot: I haz the power, 2014-10-23 02:08:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/669203002/60001

[commit-bot: I haz the power, 2014-10-23 02:18:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-23 02:19:01]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Mr4D (OOO till 08-26), 2014-10-23 04:14:47]

The CQ bit was checked by skuhne@chromium.org

[commit-bot: I haz the power, 2014-10-23 04:15:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/669203002/100001

[commit-bot: I haz the power, 2014-10-23 05:15:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-23 05:15:54]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)

[Mr4D (OOO till 08-26), 2014-10-23 13:55:57]

The CQ bit was checked by skuhne@chromium.org

[commit-bot: I haz the power, 2014-10-23 13:56:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/669203002/100001

[commit-bot: I haz the power, 2014-10-23 14:40:25]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2014-10-23 14:41:08]

Patchset 6 (id:??) landed as
https://crrev.com/4d2961fdfbb9c1bfdac9e9d77c3d3a69ba0773db
Cr-Commit-Position: refs/heads/master@{#300885}