Removing unwanted targets from all for the Athena build target

build/all.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     # A hook that can be overridden in other repositories to add additional
     # compilation targets to 'All'. Only used on Android.
     'android_app_targets%': [],
   },
@@ skipping 80 matching lines @@
         }, {
           'dependencies': [
             '../content/content_shell_and_tests.gyp:*',
             # TODO: This should build on Android and the target should move to the list above.
             '../sync/sync.gyp:*',
           ],
         }],
         ['OS!="ios" and OS!="android"', {
           'dependencies': [
             '../third_party/re2/re2.gyp:re2',
-            '../chrome/chrome.gyp:*',
             '../chrome/tools/profile_reset/jtl_compiler.gyp:*',
             '../cc/blink/cc_blink_tests.gyp:*',
             '../cc/cc_tests.gyp:*',
             '../device/bluetooth/bluetooth.gyp:*',
             '../device/device_tests.gyp:*',
             '../device/usb/usb.gyp:*',
             '../gin/gin.gyp:*',
             '../gpu/gpu.gyp:*',
             '../gpu/tools/tools.gyp:*',
             '../ipc/ipc.gyp:*',
@@ skipping 25 matching lines @@
             '../third_party/ots/ots.gyp:*',
             '../third_party/pdfium/samples/samples.gyp:*',
             '../third_party/qcms/qcms.gyp:*',
             '../tools/gn/gn.gyp:*',
             '../tools/perf/clear_system_cache/clear_system_cache.gyp:*',
             '../tools/telemetry/telemetry.gyp:*',
             '../v8/tools/gyp/v8.gyp:*',
             '<(libjpeg_gyp_path):*',
           ],
         }],
+        ['use_athena==1' , {
+          'dependencies': [
+            # Athena has to depend temporarily on Chrome. Since most tests do

[sky, 2014/10/22 17:24:11]

Your statement is a bit confusing. I think you mean something like, "Athena
temporarily depends upon a subset of chrome."

[Mr4D (OOO till 08-26), 2014/10/22 23:39:31]

Done.

+            # not compile, we only include dependencies to tests we want to
+            # build.
+            '../chrome/chrome.gyp:chrome',
+            '../chrome/chrome.gyp:browser_tests',
+          ]
+        }],

[sky, 2014/10/22 17:24:12]

Typically we use an else for this. See line 224 for the else syntax.

[Mr4D (OOO till 08-26), 2014/10/22 23:39:31]

Wohow. that "syntax" is easy to miss. Done!

+        ['use_athena==0' , {
+          'dependencies': [
+            '../chrome/chrome.gyp:*',
+          ]
+        }],
         ['OS=="mac" or OS=="ios" or OS=="win"', {
           'dependencies': [
             '../third_party/nss/nss.gyp:*',
            ],
         }],
         ['OS=="win" or OS=="ios" or OS=="linux"', {
           'dependencies': [
             '../breakpad/breakpad.gyp:*',
            ],
         }],
@@ skipping 117 matching lines @@
             '(syzyasan==1 or syzygy_optimize==1)', {
           'dependencies': [
             '../chrome/installer/mini_installer_syzygy.gyp:*',
           ],
         }],
       ],
     }, # target_name: All_syzygy
     {
       # Note: Android uses android_builder_tests below.
       # TODO: Consider merging that with this target.
       'target_name': 'chromium_builder_tests',

[sky, 2014/10/22 17:24:12]

Are you sure you don't end up pulling in this target too? Did you try an all
build locally? Make sure you do lowercase all and not All.

[Mr4D (OOO till 08-26), 2014/10/22 23:39:31]

In deed. Needed to do several rounds bout have found now all dependencies.

       'type': 'none',
       'dependencies': [
         '../base/base.gyp:base_unittests',
         '../components/components_tests.gyp:components_unittests',
         '../crypto/crypto.gyp:crypto_unittests',
         '../net/net.gyp:net_unittests',
         '../sql/sql.gyp:sql_unittests',
         '../sync/sync.gyp:sync_unit_tests',
         '../ui/base/ui_base_tests.gyp:ui_base_unittests',
         '../ui/base/ui_base_tests.gyp:ui_unittests',
@@ skipping 1036 matching lines @@
           'dependencies': [
             '../ui/views/examples/examples.gyp:views_examples_with_content_exe',
             '../ui/views/views.gyp:views',
             '../ui/views/views.gyp:views_unittests',
           ],
         },  # target_name: macviews_builder
       ],  # targets
     }],  # os=='mac' and toolkit_views==1
   ],  # conditions
 }