Issue 669198: SSLClientSocketNSS::ClientAuthHandler should return SECWouldBlock instead of SECFailure...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 669198: SSLClientSocketNSS::ClientAuthHandler should return SECWouldBlock instead of SECFailure... (Closed)

Created:
10 years, 9 months ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

SSLClientSocketNSS::ClientAuthHandler should return SECWouldBlock instead of SECFailure when we want to abort the handshake, because SECWouldBlock causes NSS to suspend the client authentication, whereas SECFailure causes NSS to continue the handshake with an empty certificate (in TLS) or no_certificate alert (in SSL 3.0). R=agl BUG=16830 TEST=SSL client authentication on Linux should still work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40785

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	net/socket/ssl_client_socket_nss.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages