Chromium Code Reviews
Help | Chromium Project | Sign in
(4)

Issue 669198: SSLClientSocketNSS::ClientAuthHandler should return SECWouldBlock instead of SECFailure... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 2 months ago by wtc
Modified:
4 years ago
Reviewers:
agl
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

SSLClientSocketNSS::ClientAuthHandler should return SECWouldBlock instead of SECFailure when we want to abort the handshake, because SECWouldBlock causes NSS to suspend the client authentication, whereas SECFailure causes NSS to continue the handshake with an empty certificate (in TLS) or no_certificate alert (in SSL 3.0). R=agl BUG=16830 TEST=SSL client authentication on Linux should still work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40785

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M net/socket/ssl_client_socket_nss.cc View 2 chunks +4 lines, -2 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 2 (0 generated)
wtc
5 years, 2 months ago (2010-03-05 21:21:23 UTC) #1
agl
5 years, 2 months ago (2010-03-05 21:24:14 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be