Chromium Code Reviews
Help | Chromium Project | Sign in
(843)

Issue 669198: SSLClientSocketNSS::ClientAuthHandler should return SECWouldBlock instead of SECFailure... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by wtc
Modified:
2 years, 11 months ago
Reviewers:
agl
CC:
chromium-reviews_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

SSLClientSocketNSS::ClientAuthHandler should return SECWouldBlock
instead of SECFailure when we want to abort the handshake, because
SECWouldBlock causes NSS to suspend the client authentication,
whereas SECFailure causes NSS to continue the handshake with an
empty certificate (in TLS) or no_certificate alert (in SSL 3.0).

R=agl
BUG=16830
TEST=SSL client authentication on Linux should still work.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40785

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Lint Patch
M net/socket/ssl_client_socket_nss.cc View 2 chunks +4 lines, -2 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 2
wtc
4 years, 1 month ago #1
agl
4 years, 1 month ago #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6