Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2155)

Unified Diff: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_configurator.h

Issue 669163003: Handle disabling data reduction proxy for all platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use IsDataReductionProxy()/ Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_configurator.h
diff --git a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_configurator.h b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_configurator.h
index 72051708f584d22c2c25363b4efefa6685496208..65e628678e9b8fb038e3ea3cc0cca18696fbaeb1 100644
--- a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_configurator.h
+++ b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_configurator.h
@@ -32,6 +32,8 @@ class DataReductionProxyChromeConfigurator
scoped_refptr<base::SequencedTaskRunner> network_task_runner);
~DataReductionProxyChromeConfigurator() override;
+ static void DisableInProxyConfigPref(PrefService* prefs);
bengr 2014/10/29 20:58:46 Add a comment.
Not at Google. Contact bengr 2014/10/29 22:30:14 Done.
+
void Enable(bool primary_restricted,
bool fallback_restricted,
const std::string& primary_origin,
@@ -61,6 +63,8 @@ class DataReductionProxyChromeConfigurator
private:
FRIEND_TEST_ALL_PREFIXES(DataReductionProxyConfigTest, TestBypassList);
+ static bool ContainsDataReductionProxy(const std::string& server);
bengr 2014/10/29 20:58:46 Add a comment describing what this does. This fun
Not at Google. Contact bengr 2014/10/29 22:30:14 Done. Good idea on passing in proxy_rules.
+
PrefService* prefs_;
scoped_refptr<base::SequencedTaskRunner> network_task_runner_;

Powered by Google App Engine
This is Rietveld 408576698