Handle disabling data reduction proxy for all platforms.

chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_configurator.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_CHROME_CONFIGURATOR_H_
 #define CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_CHROME_CONFIGURATOR_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 14 matching lines @@
 class PrefService;
 
 class DataReductionProxyChromeConfigurator
     : public data_reduction_proxy::DataReductionProxyConfigurator {
  public:
   explicit DataReductionProxyChromeConfigurator(
       PrefService* prefs,
       scoped_refptr<base::SequencedTaskRunner> network_task_runner);
   ~DataReductionProxyChromeConfigurator() override;
 
+  static void DisableInProxyConfigPref(PrefService* prefs);

[bengr, 2014/10/29 20:58:46]

Add a comment.

[Not at Google. Contact bengr, 2014/10/29 22:30:14]

Done.

+
   void Enable(bool primary_restricted,
               bool fallback_restricted,
               const std::string& primary_origin,
               const std::string& fallback_origin,
               const std::string& ssl_origin) override;
   void Disable() override;
 
   // Add a host pattern to bypass. This should follow the same syntax used
   // in net::ProxyBypassRules; that is, a hostname pattern, a hostname suffix
   // pattern, an IP literal, a CIDR block, or the magic string '<local>'.
   // Bypass settings persist for the life of this object and are applied
   // each time the proxy is enabled, but are not updated while it is enabled.
   void AddHostPatternToBypass(const std::string& pattern) override;
 
   // Add a URL pattern to bypass the proxy. The base implementation strips
   // everything in |pattern| after the first single slash and then treats it
   // as a hostname pattern. Subclasses may implement other semantics.
   void AddURLPatternToBypass(const std::string& pattern) override;
 
   // Updates the config for use on the IO thread.
   void UpdateProxyConfigOnIO(const net::ProxyConfig& config);
 
   // Returns the current data reduction proxy config, even if it is not the
   // effective configuration used by the proxy service.
   const net::ProxyConfig& GetProxyConfigOnIO() const;
 
  private:
   FRIEND_TEST_ALL_PREFIXES(DataReductionProxyConfigTest, TestBypassList);
 
+  static bool ContainsDataReductionProxy(const std::string& server);

[bengr, 2014/10/29 20:58:46]

Add a comment describing what this does.

This function would be clearer if it took a ProxyConfig::ProxyRules.

[Not at Google. Contact bengr, 2014/10/29 22:30:14]

Done.

Good idea on passing in proxy_rules.

+
   PrefService* prefs_;
   scoped_refptr<base::SequencedTaskRunner> network_task_runner_;
 
   std::vector<std::string> bypass_rules_;
   net::ProxyConfig config_;
 
   DISALLOW_COPY_AND_ASSIGN(DataReductionProxyChromeConfigurator);
 };
 
 #endif  // CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_CHROME_CONFIGURATOR_H_