Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 669163002: Fix perf profiler incorrect library collection in some cases. (Closed)

Created:
6 years, 2 months ago by Fabrice (no longer in Chrome)
Modified:
6 years, 1 month ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix perf profiler incorrect library collection in some cases. Some devices report a mysterious "[vectors]" library necessary to symbolize a given perf profile. This change makes the script ignore it. BUG=422291 Committed: https://crrev.com/332b63b253857e58a48e92cb00a6cc22239f5d47 Cr-Commit-Position: refs/heads/master@{#302836}

Patch Set 1 #

Patch Set 2 : Review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M tools/telemetry/unittest_data/sample_perf_report_output.txt View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Fabrice (no longer in Chrome)
PTAL
6 years, 2 months ago (2014-10-22 14:31:59 UTC) #2
tonyg
lgtm The style guide prefers "not path" instead of "path == ''"
6 years, 2 months ago (2014-10-22 19:44:59 UTC) #4
Sami
Would you mind adding a [vectors] line into sample_perf_report_output.txt too?
6 years, 2 months ago (2014-10-23 11:20:48 UTC) #6
Fabrice (no longer in Chrome)
On 2014/10/23 11:20:48, Sami wrote: > Would you mind adding a [vectors] line into sample_perf_report_output.txt ...
6 years, 1 month ago (2014-11-05 16:53:48 UTC) #7
tonyg
lgtm
6 years, 1 month ago (2014-11-05 16:54:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669163002/20001
6 years, 1 month ago (2014-11-05 16:55:50 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-05 18:46:56 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 18:47:39 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/332b63b253857e58a48e92cb00a6cc22239f5d47
Cr-Commit-Position: refs/heads/master@{#302836}

Powered by Google App Engine
This is Rietveld 408576698