tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py - Issue 669163002: Fix perf profiler incorrect library collection in some cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py

Issue 669163002: Fix perf profiler incorrect library collection in some cases. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py

diff --git a/tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py b/tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py

index a6c2a6f66160e365d73f987801e8264cb72f15a9..d8736079d03a38c9836ca999cc30106f5e007073 100644

--- a/tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py

+++ b/tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py

@@ -118,8 +118,9 @@ def GetRequiredLibrariesForPerfProfile(profile_file):

if lib:

lib = lib.group(1)

path = os.path.dirname(lib)

- if any(path.startswith(ignored_path)

- for ignored_path in _IGNORED_LIB_PATHS) or path == '/':

+ if (any(path.startswith(ignored_path)

+ for ignored_path in _IGNORED_LIB_PATHS)

+ or path == '/' or not path):

continue

libs.add(lib)

return libs

« no previous file with comments | « no previous file | tools/telemetry/unittest_data/sample_perf_report_output.txt » ('j') | no next file with comments »