Issue 669123005: DevTools: [JSDocValidator] Pass JS file names through a temporary file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 669123005: DevTools: [JSDocValidator] Pass JS file names through a temporary file (Closed)

Created:
6 years, 1 month ago by apavlov

Modified:
6 years, 1 month ago

Reviewers:
sergeyv

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: [JSDocValidator] Pass JS file names through a temporary file This is required for the validator to work on Windows, as otherwise the command line exceeds the maximum length there. R=sergeyv@chromium.org, sergeyv Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184358

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -6 lines)			Patch
M	Source/devtools/scripts/compile_frontend.py	View	3 chunks	+9 lines, -2 lines	0 comments	Download
M	Source/devtools/scripts/jsdoc-validator/hashes	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/devtools/scripts/jsdoc-validator/jsdoc-validator.jar	View	Binary file		0 comments	Download
M	Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/JsDocValidator.java	View	2 chunks	+35 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669123005/1

6 years, 1 month ago (2014-10-24 13:49:11 UTC) #4

apavlov

6 years, 1 month ago (2014-10-24 13:55:16 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 184358 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages