Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 669123005: DevTools: [JSDocValidator] Pass JS file names through a temporary file (Closed)

Created:
6 years, 1 month ago by apavlov
Modified:
6 years, 1 month ago
Reviewers:
sergeyv
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: [JSDocValidator] Pass JS file names through a temporary file This is required for the validator to work on Windows, as otherwise the command line exceeds the maximum length there. R=sergeyv@chromium.org, sergeyv Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184358

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -6 lines) Patch
M Source/devtools/scripts/compile_frontend.py View 3 chunks +9 lines, -2 lines 0 comments Download
M Source/devtools/scripts/jsdoc-validator/hashes View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/scripts/jsdoc-validator/jsdoc-validator.jar View Binary file 0 comments Download
M Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/JsDocValidator.java View 2 chunks +35 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
apavlov
6 years, 1 month ago (2014-10-24 13:30:59 UTC) #1
sergeyv
lgtm
6 years, 1 month ago (2014-10-24 13:48:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669123005/1
6 years, 1 month ago (2014-10-24 13:49:11 UTC) #4
apavlov
6 years, 1 month ago (2014-10-24 13:55:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 184358 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698