DevTools: [JSDocValidator] Pass JS file names through a temporary file

Source/devtools/scripts/compile_frontend.py

 #!/usr/bin/env python
 # Copyright (c) 2012 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
@@ skipping 85 matching lines @@
 
 def run_in_shell(command_line):
     return subprocess.Popen(command_line, stdout=subprocess.PIPE, stderr=subprocess.STDOUT, shell=True)
 
 
 def hasErrors(output):
     return re.search(error_warning_regex, output) != None
 
 
 def verify_jsdoc_extra(additional_files):
-    return run_in_shell('%s -jar %s %s' % (java_exec, jsdoc_validator_jar, ' '.join(descriptors.all_compiled_files() + additional_files)))
+    file_list = tempfile.NamedTemporaryFile(mode='wt', delete=False)
+    try:
+        file_list.write('\n'.join(descriptors.all_compiled_files() + additional_files))
+    finally:
+        file_list.close()
+    return run_in_shell('%s -jar %s --files-list-name %s' % (java_exec, jsdoc_validator_jar, file_list.name)), file_list
 
 
 def verify_jsdoc(additional_files):
     def file_list():
         return descriptors.all_compiled_files() + additional_files
 
     errors_found = False
     for full_file_name in file_list():
         lineIndex = 0
         with open(full_file_name, 'r') as sourceFile:
@@ skipping 185 matching lines @@
 command += '        --js ' + injectedScriptSourceTmpFile + ' \\\n'
 command += '    --module ' + jsmodule_name_prefix + 'injected_canvas_script' + ':1:' + jsmodule_name_prefix + 'injected_script' + ' \\\n'
 command += '        --js ' + injectedScriptCanvasModuleSourceTmpFile + ' \\\n'
 command += '\n'
 
 injectedScriptCompileProc = run_in_shell(command)
 
 print 'Verifying JSDoc comments...'
 additional_jsdoc_check_files = [injectedScriptSourceTmpFile, injectedScriptCanvasModuleSourceTmpFile]
 errors_found |= verify_jsdoc(additional_jsdoc_check_files)
-jsdocValidatorProc = verify_jsdoc_extra(additional_jsdoc_check_files)
+jsdocValidatorProc, jsdocValidatorFileList = verify_jsdoc_extra(additional_jsdoc_check_files)
 
 print 'Checking generated code in InjectedScriptCanvasModuleSource.js...'
 check_injected_webgl_calls_command = '%s/check_injected_webgl_calls_info.py %s %s' % (scripts_path, webgl_rendering_context_idl_path, canvas_injected_script_source_name)
 canvasModuleCompileProc = run_in_shell(check_injected_webgl_calls_command)
 
 print 'Validating InjectedScriptSource.js...'
 check_injected_script_command = '%s/check_injected_script_source.py %s' % (scripts_path, injected_script_source_name)
 validateInjectedScriptProc = run_in_shell(check_injected_script_command)
 
 print
 
 (jsdocValidatorOut, _) = jsdocValidatorProc.communicate()
 if jsdocValidatorOut:
     print ('JSDoc validator output:\n%s' % jsdocValidatorOut)
     errors_found = True
 
+os.remove(jsdocValidatorFileList.name)
+
 (moduleCompileOut, _) = modular_compiler_proc.communicate()
 print 'Modular compilation output:'
 
 start_module_regex = re.compile(r'^@@ START_MODULE:(.+) @@$')
 end_module_regex = re.compile(r'^@@ END_MODULE @@$')
 
 in_module = False
 skipped_modules = {}
 error_count = 0
 
@@ skipping 52 matching lines @@
 
 if errors_found:
     print 'ERRORS DETECTED'
 
 os.remove(injectedScriptSourceTmpFile)
 os.remove(injectedScriptCanvasModuleSourceTmpFile)
 os.remove(compiler_args_file.name)
 os.remove(injected_script_externs_file.name)
 os.remove(protocol_externs_file)
 shutil.rmtree(modules_dir, True)