Fixed Shadow blur for transparent objects

Source/platform/graphics/GraphicsContextState.cpp

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "platform/graphics/GraphicsContextState.h"
 
 #include "platform/graphics/skia/SkiaUtils.h"
 
 namespace blink {
@@ skipping 29 matching lines @@
     , m_fillPaint(other.m_fillPaint)
     , m_strokeData(other.m_strokeData)
     , m_strokeColor(other.m_strokeColor)
     , m_strokeGradient(other.m_strokeGradient)
     , m_strokePattern(other.m_strokePattern)
     , m_fillColor(other.m_fillColor)
     , m_fillRule(other.m_fillRule)
     , m_fillGradient(other.m_fillGradient)
     , m_fillPattern(other.m_fillPattern)
     , m_looper(other.m_looper)
+    , m_imageFilter(other.m_imageFilter)
     , m_textDrawingMode(other.m_textDrawingMode)
     , m_alpha(other.m_alpha)
     , m_colorFilter(other.m_colorFilter)
     , m_compositeOperator(other.m_compositeOperator)
     , m_blendMode(other.m_blendMode)
     , m_interpolationQuality(other.m_interpolationQuality)
     , m_saveCount(0)
     , m_shouldAntialias(other.m_shouldAntialias)
     , m_shouldClampToSourceRect(other.m_shouldClampToSourceRect) { }
 
@@ skipping 137 matching lines @@
     m_fillPaint.setLooper(m_looper.get());
 }
 
 void GraphicsContextState::clearDrawLooper()
 {
     m_looper.clear();
     m_strokePaint.setLooper(0);
     m_fillPaint.setLooper(0);
 }
 
+// Shadow. (This will need tweaking if we use image filters for other things.)

[Stephen White, 2014/10/23 01:45:47]

Pls remove this comment.

[sugoi1, 2014/10/23 17:43:17]

Done.

+void GraphicsContextState::setImageFilter(PassRefPtr<SkImageFilter> imageFilter)
+{
+    m_imageFilter = imageFilter;
+    m_strokePaint.setImageFilter(m_imageFilter.get());

[Stephen White, 2014/10/23 01:45:47]

I don't think this is correct. If we set an image filter in the paint, it will
be active at the same time as the draw looper. I think we should use it only in
the setup for drawRectToRect.

This also may be why you're getting more layout test failures than expected.

[sugoi1, 2014/10/23 17:43:17]

Done.

+    m_fillPaint.setImageFilter(m_imageFilter.get());
+}
+
+void GraphicsContextState::clearImageFilter()
+{
+    m_imageFilter.clear();
+    m_strokePaint.setImageFilter(0);

[Stephen White, 2014/10/23 01:45:47]

Same here.

[sugoi1, 2014/10/23 17:43:17]

Done.

+    m_fillPaint.setImageFilter(0);
+}
+
 void GraphicsContextState::setAlphaAsFloat(float alpha)
 {
     if (alpha < 0) {
         m_alpha = 0;
     } else {
         m_alpha = roundf(alpha * 256);
         if (m_alpha > 256)
             m_alpha = 256;
     }
     m_strokePaint.setColor(applyAlpha(m_strokeColor.rgb()));
@@ skipping 30 matching lines @@
 
 void GraphicsContextState::setShouldAntialias(bool shouldAntialias)
 {
     m_shouldAntialias = shouldAntialias;
     m_strokePaint.setAntiAlias(shouldAntialias);
     m_fillPaint.setAntiAlias(shouldAntialias);
 }
 
 
 } // namespace blink