Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 669093002: RenderStyle operator== incorrect for shape-outside and clip-path. (Closed)

Created:
6 years, 2 months ago by rune
Modified:
6 years, 2 months ago
Reviewers:
dstockwell, esprehn
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-rendering, dstockwell, eae+blinkwatch, Eric Willigers, jchaffraix+rendering, leviw+renderwatch, Mike Lawther (Google), pdr+renderingwatchlist_chromium.org, rjwright, rune+blink, shans, Steve Block, Timothy Loh, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

RenderStyle operator== incorrect for shape-outside and clip-path. Use dataEquivalent instead of comparing pointers. Updating the base RenderStyle in ActiveAnimations asserts that the cached base RenderStyle is correct by comparing RenderStyle objects. It triggered an assert when comparing two shape-outside values represented by different objects representing the same value. R=esprehn@chromium.org,dstockwell@chromium.org BUG=425473 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184345

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -6 lines) Patch
A LayoutTests/transitions/transition-shape-outside-crash.html View 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/transitions/transition-shape-outside-crash-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A Source/core/rendering/style/RenderStyleTest.cpp View 1 chunk +53 lines, -0 lines 0 comments Download
M Source/core/rendering/style/ShapeValue.h View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.cpp View 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
rune
6 years, 2 months ago (2014-10-22 10:39:50 UTC) #1
rune
I've looked through RefPtr and OwnPtr members in RenderStyle and friends and didn't find more ...
6 years, 2 months ago (2014-10-22 11:01:17 UTC) #2
rune
PTAL
6 years, 2 months ago (2014-10-24 08:44:33 UTC) #3
dstockwell
lgtm
6 years, 2 months ago (2014-10-24 08:55:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669093002/1
6 years, 2 months ago (2014-10-24 08:57:01 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 10:01:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184345

Powered by Google App Engine
This is Rietveld 408576698