Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1192)

Unified Diff: Source/core/rendering/style/ShapeValue.h

Issue 669093002: RenderStyle operator== incorrect for shape-outside and clip-path. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/style/ShapeValue.h
diff --git a/Source/core/rendering/style/ShapeValue.h b/Source/core/rendering/style/ShapeValue.h
index 34de7741b1ad740be0f7041ed8ee4530b555c26b..5d846b6cc3d211b2156b5eade47404bc779f24e6 100644
--- a/Source/core/rendering/style/ShapeValue.h
+++ b/Source/core/rendering/style/ShapeValue.h
@@ -32,6 +32,7 @@
#include "core/fetch/ImageResource.h"
#include "core/rendering/style/BasicShapes.h"
+#include "core/rendering/style/DataEquivalency.h"
#include "core/rendering/style/RenderStyleConstants.h"
#include "core/rendering/style/StyleImage.h"
#include "wtf/PassRefPtr.h"
@@ -122,11 +123,11 @@ inline bool ShapeValue::operator==(const ShapeValue& other) const
switch (type()) {
case Shape:
- return shape() == other.shape() && cssBox() == other.cssBox();
+ return dataEquivalent(shape(), other.shape()) && cssBox() == other.cssBox();
case Box:
return cssBox() == other.cssBox();
case Image:
- return image() == other.image();
+ return dataEquivalent(image(), other.image());
}
ASSERT_NOT_REACHED();
« no previous file with comments | « Source/core/rendering/style/RenderStyleTest.cpp ('k') | Source/core/rendering/style/StyleRareNonInheritedData.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698