content/browser/loader/resource_loader.cc - Issue 669073003: Get rid of net::LOAD_ENABLE_UPLOAD_PROGRESS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/resource_loader.cc

Issue 669073003: Get rid of net::LOAD_ENABLE_UPLOAD_PROGRESS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed uninitialized value use. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/loader/resource_loader.cc

diff --git a/content/browser/loader/resource_loader.cc b/content/browser/loader/resource_loader.cc

index df90d4bed87b6964ae16ab9f1e62841372a5ce41..21e0b0056130b542c2a5befefc6ba2880edf2635 100644

--- a/content/browser/loader/resource_loader.cc

+++ b/content/browser/loader/resource_loader.cc

@@ -159,7 +159,8 @@ void ResourceLoader::ReportUploadProgress() {

bool too_much_time_passed = time_since_last > kOneSecond;

if (is_finished || enough_new_progress || too_much_time_passed) {

- if (request_->load_flags() & net::LOAD_ENABLE_UPLOAD_PROGRESS) {

+ ResourceRequestInfoImpl* info = GetRequestInfo();

+ if (info->is_upload_progress_enabled()) {

handler_->OnUploadProgress(progress.position(), progress.size());

waiting_for_upload_progress_ack_ = true;

}