Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 669010: Link setup script for chrome UI tests. (Closed)

Created:
10 years, 9 months ago by zel
Modified:
9 years, 6 months ago
Reviewers:
petkov
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Link setup script for chrome UI tests.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
A src/tests/scripts/setup_test_links.sh View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zel
10 years, 9 months ago (2010-03-03 23:44:17 UTC) #1
petkov
Is this the main repo? It seems it is... This is the wrong place for ...
10 years, 9 months ago (2010-03-03 23:55:14 UTC) #2
zel
10 years, 9 months ago (2010-03-04 00:10:53 UTC) #3
I am abandoning this CL since this file is now moved to autotest repo.
Please take a look at CL http://codereview.chromium.org/661476 instead.



On Wed, Mar 3, 2010 at 3:55 PM, <petkov@chromium.org> wrote:

> Is this the main repo? It seems it is... This is the wrong place for this
> script
> -- nobody uses src/tests any more -- it should be deleted.
>
> Can you move this to the autotest repo, under deps/chrome_tests? Also, I
> suspect
> you would need to use $(dirname $0) to get symlink location right.
>
> Then the test could invoke it:
>
> dep_dir = os.path.join(self.autodir, 'deps', 'chrome_test')
> utils.system(dep_dir + '/setup_symlinks.sh')
>
> Also, add a copyright.
>
>
>
> http://codereview.chromium.org/669010
>

Powered by Google App Engine
This is Rietveld 408576698