Chrome's UI automation tests (browser_test) added as autotest

Chrome browser_test added as autotest

[petkov, 2010-03-03 18:53:02]

Mostly nits.

http://codereview.chromium.org/661476/diff/1/3
File client/deps/chrome_test/chrome_test.py (right):

http://codereview.chromium.org/661476/diff/1/3#newcode7
client/deps/chrome_test/chrome_test.py:7: import common, commands, logging, os,
shutil
Remove unused modules?

http://codereview.chromium.org/661476/diff/1/3#newcode20
client/deps/chrome_test/chrome_test.py:20: # shutil.copytree(chrome_test_files,
testsrc_dir)
Remove comment.

http://codereview.chromium.org/661476/diff/1/7
File client/site_tests/desktopui_BrowserTest/desktopui_BrowserTest.py (right):

http://codereview.chromium.org/661476/diff/1/7#newcode18
client/site_tests/desktopui_BrowserTest/desktopui_BrowserTest.py:18: def
run_once(self):
Two empty lines between methods per local CODING_STYLE.

http://codereview.chromium.org/661476/diff/1/7#newcode26
client/site_tests/desktopui_BrowserTest/desktopui_BrowserTest.py:26:
environment_vars = \
Remove this -- use site_ui.xcommand() to wrap the X command instead. See for
example audiovideo_V4L2. This way it will be easier to propagate X related
changes across tests.

http://codereview.chromium.org/661476/diff/1/7#newcode29
client/site_tests/desktopui_BrowserTest/desktopui_BrowserTest.py:29: # Create
magic symlinks to real chrome bits.
I thought you were going to create the symlinks as part of the deps/chrome_test?
Otherwise every test that relies on it would need to create them -- i.e.,
copy/paste the code below.
Alternatively, maybe provide a utility routine as part of chrome_test to create
the symlinks?

[zel, 2010-03-03 23:52:27]

http://codereview.chromium.org/661476/diff/1/3
File client/deps/chrome_test/chrome_test.py (right):

http://codereview.chromium.org/661476/diff/1/3#newcode7
client/deps/chrome_test/chrome_test.py:7: import common, commands, logging, os,
shutil
On 2010/03/03 18:53:02, petkov wrote:
> Remove unused modules?

Done.

http://codereview.chromium.org/661476/diff/1/3#newcode20
client/deps/chrome_test/chrome_test.py:20: # shutil.copytree(chrome_test_files,
testsrc_dir)
On 2010/03/03 18:53:02, petkov wrote:
> Remove comment.
> 

Done.

http://codereview.chromium.org/661476/diff/1/7
File client/site_tests/desktopui_BrowserTest/desktopui_BrowserTest.py (right):

http://codereview.chromium.org/661476/diff/1/7#newcode18
client/site_tests/desktopui_BrowserTest/desktopui_BrowserTest.py:18: def
run_once(self):
On 2010/03/03 18:53:02, petkov wrote:
> Two empty lines between methods per local CODING_STYLE.
> 

Done.

http://codereview.chromium.org/661476/diff/1/7#newcode29
client/site_tests/desktopui_BrowserTest/desktopui_BrowserTest.py:29: # Create
magic symlinks to real chrome bits.
On 2010/03/03 18:53:02, petkov wrote:
> I thought you were going to create the symlinks as part of the
deps/chrome_test?
> Otherwise every test that relies on it would need to create them -- i.e.,
> copy/paste the code below.
> Alternatively, maybe provide a utility routine as part of chrome_test to
create
> the symlinks?
> 

I tired to do this in chrome_test, but bzip file did not transfer them over. I
will create a utility script instead.

[petkov, 2010-03-04 00:14:25]

http://codereview.chromium.org/661476/diff/4009/4016
File client/site_tests/desktopui_BrowserTest/desktopui_BrowserTest.py (right):

http://codereview.chromium.org/661476/diff/4009/4016#newcode30
client/site_tests/desktopui_BrowserTest/desktopui_BrowserTest.py:30:
utils.run('ln -f -s %s/chrome %s/chrome' %
Do you need to remove these symlink creation steps now that this is done by
setup_test_links.sh?

[zel, 2010-03-04 00:23:21]

http://codereview.chromium.org/661476/diff/4009/4016
File client/site_tests/desktopui_BrowserTest/desktopui_BrowserTest.py (right):

http://codereview.chromium.org/661476/diff/4009/4016#newcode30
client/site_tests/desktopui_BrowserTest/desktopui_BrowserTest.py:30:
utils.run('ln -f -s %s/chrome %s/chrome' %
On 2010/03/04 00:14:25, petkov wrote:
> Do you need to remove these symlink creation steps now that this is done by
> setup_test_links.sh?

Yes, of course... Done.

[petkov, 2010-03-04 00:24:21]

LGTM

[petkov, 2010-03-04 00:25:25]

http://codereview.chromium.org/661476/diff/3012/4025
File client/site_tests/desktopui_BrowserTest/desktopui_BrowserTest.py (right):

http://codereview.chromium.org/661476/diff/3012/4025#newcode26
client/site_tests/desktopui_BrowserTest/desktopui_BrowserTest.py:26: # Create
magic symlinks to real chrome bits.
Remove/move this comment before submitting if you get this in time...

[zel, 2010-03-04 00:37:44]

http://codereview.chromium.org/661476/diff/3012/4025
File client/site_tests/desktopui_BrowserTest/desktopui_BrowserTest.py (right):

http://codereview.chromium.org/661476/diff/3012/4025#newcode26
client/site_tests/desktopui_BrowserTest/desktopui_BrowserTest.py:26: # Create
magic symlinks to real chrome bits.
On 2010/03/04 00:25:25, petkov wrote:
> Remove/move this comment before submitting if you get this in time...
> 

Done.