Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: chrome/browser/apps/drive/drive_app_provider_browsertest.cc

Issue 668903002: Standardize usage of virtual/override/final in chrome/browser/apps/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/apps/drive/drive_app_provider.h ('k') | chrome/browser/apps/drive/drive_service_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/drive/drive_app_provider_browsertest.cc
diff --git a/chrome/browser/apps/drive/drive_app_provider_browsertest.cc b/chrome/browser/apps/drive/drive_app_provider_browsertest.cc
index ee2b462d4bb5d809a3858e959670feea7b25d608..4adac22cae5193af4737686df4adec4d99d636e6 100644
--- a/chrome/browser/apps/drive/drive_app_provider_browsertest.cc
+++ b/chrome/browser/apps/drive/drive_app_provider_browsertest.cc
@@ -48,11 +48,9 @@ class TestDriveServiceBridge : public DriveServiceBridge {
public:
explicit TestDriveServiceBridge(drive::DriveAppRegistry* registry)
: registry_(registry) {}
- virtual ~TestDriveServiceBridge() {}
+ ~TestDriveServiceBridge() override {}
- virtual drive::DriveAppRegistry* GetAppRegistry() override {
- return registry_;
- }
+ drive::DriveAppRegistry* GetAppRegistry() override { return registry_; }
private:
drive::DriveAppRegistry* registry_;
@@ -63,7 +61,7 @@ class TestDriveServiceBridge : public DriveServiceBridge {
class FakeUninstallSyncService : public DriveAppUninstallSyncService {
public:
FakeUninstallSyncService() {}
- virtual ~FakeUninstallSyncService() {}
+ ~FakeUninstallSyncService() override {}
bool IsUninstallTracked(const std::string& drive_app_id) const {
return uninstalled_app_ids_.find(drive_app_id) !=
@@ -71,12 +69,10 @@ class FakeUninstallSyncService : public DriveAppUninstallSyncService {
}
// DriveAppUninstallSyncService
- virtual void TrackUninstalledDriveApp(
- const std::string& drive_app_id) override {
+ void TrackUninstalledDriveApp(const std::string& drive_app_id) override {
uninstalled_app_ids_.insert(drive_app_id);
}
- virtual void UntrackUninstalledDriveApp(
- const std::string& drive_app_id) override {
+ void UntrackUninstalledDriveApp(const std::string& drive_app_id) override {
auto it = uninstalled_app_ids_.find(drive_app_id);
if (it == uninstalled_app_ids_.end())
return;
@@ -98,7 +94,7 @@ class DriveAppProviderTest : public ExtensionBrowserTest,
virtual ~DriveAppProviderTest() {}
// ExtensionBrowserTest:
- virtual void SetUpOnMainThread() override {
+ void SetUpOnMainThread() override {
ExtensionBrowserTest::SetUpOnMainThread();
fake_drive_service_.reset(new drive::FakeDriveService);
@@ -119,7 +115,7 @@ class DriveAppProviderTest : public ExtensionBrowserTest,
->ResetDriveAppProviderForTest();
}
- virtual void TearDownOnMainThread() override {
+ void TearDownOnMainThread() override {
provider_.reset();
apps_registry_.reset();
fake_drive_service_.reset();
@@ -207,8 +203,8 @@ class DriveAppProviderTest : public ExtensionBrowserTest,
}
// extensions::InstallObserver
- virtual void OnFinishCrxInstall(const std::string& extension_id,
- bool success) override {
+ void OnFinishCrxInstall(const std::string& extension_id,
+ bool success) override {
runner_->Quit();
}
« no previous file with comments | « chrome/browser/apps/drive/drive_app_provider.h ('k') | chrome/browser/apps/drive/drive_service_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698