tools/telemetry/telemetry/core/backends/webdriver/webdriver_tab_backend.py - Issue 668753002: [Telemetry] Migrate bitmap.py from bitmaptools.cc to numpy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/webdriver/webdriver_tab_backend.py

Issue 668753002: [Telemetry] Migrate bitmap.py from bitmaptools.cc to numpy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py ('k') | tools/telemetry/telemetry/core/bitmap.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/webdriver/webdriver_tab_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/webdriver/webdriver_tab_backend.py b/tools/telemetry/telemetry/core/backends/webdriver/webdriver_tab_backend.py

index 29e7627d6f90718a0a79fd1c8da9472173bdbbe3..9e80f87a230ef0af2af103fa138e1ad4013e2a4b 100644

--- a/tools/telemetry/telemetry/core/backends/webdriver/webdriver_tab_backend.py

+++ b/tools/telemetry/telemetry/core/backends/webdriver/webdriver_tab_backend.py

@@ -4,7 +4,7 @@

import logging

-from telemetry.core import bitmap

+from telemetry.image_processing import image_util

class WebDriverTabBackend(object):

@@ -51,7 +51,7 @@ class WebDriverTabBackend(object):

self._browser_backend.driver.switch_to_window(self._window_handle)

snap = self._browser_backend.driver.get_screenshot_as_base64()

if snap:

- return bitmap.Bitmap.FromPng(snap)

+ return image_util.FromPng(snap)

return None

@property