tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py - Issue 668753002: [Telemetry] Migrate bitmap.py from bitmaptools.cc to numpy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py

Issue 668753002: [Telemetry] Migrate bitmap.py from bitmaptools.cc to numpy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/_bitmap.py ('k') | tools/telemetry/telemetry/core/backends/webdriver/webdriver_tab_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py

index 23de53f70ff7898e666de132fd585207b656a199..5b2eee26e6a5070e077556eb5d3d03317d70c63a 100644

--- a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py

@@ -7,7 +7,6 @@ import os

import sys

from telemetry import decorators

-from telemetry.core import bitmap

from telemetry.core import exceptions

from telemetry.core import util

from telemetry.core.backends.chrome_inspector import inspector_console

@@ -19,6 +18,7 @@ from telemetry.core.backends.chrome_inspector import inspector_timeline

from telemetry.core.backends.chrome_inspector import inspector_websocket

from telemetry.core.backends.chrome_inspector import websocket

from telemetry.core.heap import model

+from telemetry.image_processing import image_util

from telemetry.timeline import model as timeline_model

from telemetry.timeline import recording_options

@@ -128,7 +128,7 @@ class InspectorBackend(inspector_websocket.InspectorWebsocket):

})()

""")

if snap:

- return bitmap.Bitmap.FromBase64Png(snap['data'])

+ return image_util.FromBase64Png(snap['data'])

return None

# Console public methods.