C++ overload resolution in bindings layer

C++ overload resolution in bindings layer

This CL adds generation of C++ overload resolution functions to the bindings generation scripts.  The overload resolution code was pulled over from the V8 scripts and templates and modified for Dart.

The resolver generation was modified so that resolver strings are not mangled with type names, and all of the resolvers for overloaded methods target the C++ overload dispatcher.

BUG=
R=vsm@google.com

Committed: https://src.chromium.org/viewvc/blink/branches/dart/dartium?view=rev&revision=184118

[Leaf, 2014-10-21 17:05:26]

leafp@google.com changed reviewers:
+ terry@google.com, vsm@google.com

[Leaf, 2014-10-21 17:08:25]

Example dispatcher here:

static void texImage2DCallbackDispatcher(Dart_NativeArguments args)
{
    Dart_Handle exception = 0;
    const int argOffset = 1;
    int argCount = Dart_GetNativeArgumentCount(args) - argOffset;

    switch (std::min(9, argCount)) {
    case 6:
        if (Dart_IsNull(Dart_GetNativeArgument(args, 5 + argOffset))) {
            texImage2DCallback_2(args);
            return;
        }
        if (DartImageData::hasInstance(Dart_GetNativeArgument(args, 5 +
argOffset))) {
            texImage2DCallback_2(args);
            return;
        }
        if (DartHTMLImageElement::hasInstance(Dart_GetNativeArgument(args, 5 +
argOffset))) {
            texImage2DCallback_3(args);
            return;
        }
        if (DartHTMLCanvasElement::hasInstance(Dart_GetNativeArgument(args, 5 +
argOffset))) {
            texImage2DCallback_4(args);
            return;
        }
        if (DartHTMLVideoElement::hasInstance(Dart_GetNativeArgument(args, 5 +
argOffset))) {
            texImage2DCallback_5(args);
            return;
        }
        break;
    case 9:
        if (true) {
            texImage2DCallback_1(args);
            return;
        }
        break;
    default:
        if (argCount >= 6) {
            const String message = "Wrong arity, expected one of [6, 9]";
            exception = DartUtilities::coreArgumentErrorException(message);
            goto fail;
        }
        {
            const String message = "Not enough arguments (at least 6 required)";
            exception = DartUtilities::coreArgumentErrorException(message);
            goto fail;
        }
        return;
    }
    {
        const String message = "No function was found that matched the signature
provided.";
        exception = DartUtilities::coreArgumentErrorException(message);
        goto fail;
    }
    return;
fail:
    Dart_ThrowException(exception);
    ASSERT_NOT_REACHED();
}

[vsm, 2014-10-21 19:49:19]

lgtm

How much does the overload logic mirror V8?  Is there a possibility of reusing
V8 as per Terry's CLs?

[Leaf, 2014-10-21 20:07:45]

It mirrors it pretty closely, mostly differing just in the specifics of how the
instance checks are done.  I briefly tried re-using the V8 code, but ran into
monkey-patching trouble and didn't pursue it further - it looked like loading
v8_interface.py into dart_interface.py was causing some monkey-patches to
interfere with the dart versions.  Since Terry has made this work elsewhere, I
might go back and take another crack at re-factoring this out, but wanted to get
the main thing checked in first.

On 2014/10/21 19:49:19, vsm wrote:
> lgtm
> 
> How much does the overload logic mirror V8?  Is there a possibility of reusing
> V8 as per Terry's CLs?

[Leaf, 2014-10-21 20:41:33]

Committed patchset #4 (id:60001) manually as 184118 (presubmit successful).

[terry, 2014-10-21 21:26:12]

lgtm just minor suggestions.

https://codereview.chromium.org/668733002/diff/60001/Source/bindings/dart/scr...
File Source/bindings/dart/scripts/dart_interface.py (right):

https://codereview.chromium.org/668733002/diff/60001/Source/bindings/dart/scr...
Source/bindings/dart/scripts/dart_interface.py:717: def
compute_method_overloads_context(methods):
methods => method_contexts ?

We use method(s) as both context(s) and method(s) which seems confusing.  I've
tried to change other mechanisms to context when context is used and vice versa.
 I can also do that after this checkin when I cleanup dart_interface w/
v8_interface.

https://codereview.chromium.org/668733002/diff/60001/Source/bindings/dart/scr...
Source/bindings/dart/scripts/dart_interface.py:803: def
effective_overload_set(F):
F or f, used f for function in below methods.

https://codereview.chromium.org/668733002/diff/60001/Source/bindings/dart/scr...
Source/bindings/dart/scripts/dart_interface.py:843: S = []
capitalized? as well as others

https://codereview.chromium.org/668733002/diff/60001/Source/bindings/dart/scr...
Source/bindings/dart/scripts/dart_interface.py:998: """Yields resolution test
and associated method, in resolution order, for effective overloads of a given
length.
linebreak?

[siva, 2014-10-22 01:13:02]

asiva@google.com changed reviewers:
+ asiva@google.com

[siva, 2014-10-22 01:13:03]

DBC

https://codereview.chromium.org/668733002/diff/60001/Source/bindings/core/dar...
File Source/bindings/core/dart/DartUtilities.cpp (right):

https://codereview.chromium.org/668733002/diff/60001/Source/bindings/core/dar...
Source/bindings/core/dart/DartUtilities.cpp:987: return
Dart_GetTypeOfTypedData(object) == Dart_TypedData_kUint8Clamped;
Ditto question about 

kExternalTypedDataUint8ClampedArrayCid
kTypedDataUint8ClampedArrayViewCid

https://codereview.chromium.org/668733002/diff/60001/Source/bindings/core/dar...
Source/bindings/core/dart/DartUtilities.cpp:1327: Dart_Handle errorClass =
Dart_GetType(coreLib, stringToDart(className), 0, 0);
You could use domData->coreLibrary() here instead of looking up coreLib again.

https://codereview.chromium.org/668733002/diff/60001/Source/bindings/core/dar...
Source/bindings/core/dart/DartUtilities.cpp:1329: Dart_Handle error =
Dart_New(errorClass, Dart_NewStringFromCString(""), 1, &dartMessage);
Dart_EmptyString() instead of creating another new string

[Leaf, 2014-10-22 16:31:19]

https://codereview.chromium.org/668733002/diff/60001/Source/bindings/core/dar...
File Source/bindings/core/dart/DartUtilities.cpp (right):

https://codereview.chromium.org/668733002/diff/60001/Source/bindings/core/dar...
Source/bindings/core/dart/DartUtilities.cpp:987: return
Dart_GetTypeOfTypedData(object) == Dart_TypedData_kUint8Clamped;
Sorry, what was the question?

On 2014/10/22 01:13:03, siva wrote:
> Ditto question about 
> 
> kExternalTypedDataUint8ClampedArrayCid
> kTypedDataUint8ClampedArrayViewCid

https://codereview.chromium.org/668733002/diff/60001/Source/bindings/core/dar...
Source/bindings/core/dart/DartUtilities.cpp:1327: Dart_Handle errorClass =
Dart_GetType(coreLib, stringToDart(className), 0, 0);
Great thanks, will change in followup.

On 2014/10/22 01:13:03, siva wrote:
> You could use domData->coreLibrary() here instead of looking up coreLib again.

https://codereview.chromium.org/668733002/diff/60001/Source/bindings/core/dar...
Source/bindings/core/dart/DartUtilities.cpp:1329: Dart_Handle error =
Dart_New(errorClass, Dart_NewStringFromCString(""), 1, &dartMessage);
On 2014/10/22 01:13:03, siva wrote:
> Dart_EmptyString() instead of creating another new string

Acknowledged.

https://codereview.chromium.org/668733002/diff/60001/Source/bindings/dart/scr...
File Source/bindings/dart/scripts/dart_interface.py (right):

https://codereview.chromium.org/668733002/diff/60001/Source/bindings/dart/scr...
Source/bindings/dart/scripts/dart_interface.py:717: def
compute_method_overloads_context(methods):
Kind of trying to minimize text changes vs v8 to make porting changes easier,
but don't mind if we want to change this.

On 2014/10/21 21:26:11, terry wrote:
> methods => method_contexts ?
> 
> We use method(s) as both context(s) and method(s) which seems confusing.  I've
> tried to change other mechanisms to context when context is used and vice
versa.
>  I can also do that after this checkin when I cleanup dart_interface w/
> v8_interface.

https://codereview.chromium.org/668733002/diff/60001/Source/bindings/dart/scr...
Source/bindings/dart/scripts/dart_interface.py:803: def
effective_overload_set(F):
I think the odd capitalization and typography in this method are intended to
follow the Web IDL overload resolution text as closely as possible: 
http://heycam.github.io/webidl/#dfn-effective-overload-set .

On 2014/10/21 21:26:12, terry wrote:
> F or f, used f for function in below methods.