Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: Source/bindings/dart/scripts/dart_utilities.py

Issue 668733002: C++ overload resolution in bindings layer (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/dartium
Patch Set: Rebase fixups Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/dart/scripts/dart_utilities.py
diff --git a/Source/bindings/dart/scripts/dart_utilities.py b/Source/bindings/dart/scripts/dart_utilities.py
index b9f191e74796064d7fbecd5d36fb8ab3e6f2374c..cf231cf1cbfa1ac095083ab4f9296157e35dd8b1 100644
--- a/Source/bindings/dart/scripts/dart_utilities.py
+++ b/Source/bindings/dart/scripts/dart_utilities.py
@@ -132,9 +132,7 @@ def _measure_as(definition_or_member):
return extended_attributes['MeasureAs']
-def _generate_native_entry(interface_name, thing, name, kind,
- optional_index, args, types):
- index = thing.get('overload_index') or optional_index
+def _generate_native_entry(interface_name, thing, name, kind, args):
is_static = bool(thing.get('is_static'))
tag = ""
if kind == 'Getter':
@@ -146,17 +144,10 @@ def _generate_native_entry(interface_name, thing, name, kind,
elif kind == 'Constructor':
tag = "constructorCallback"
blink_entry = tag
- if index is not None:
- blink_entry = "_create_%s%s" % (index, blink_entry)
elif kind == 'Method':
tag = "%s_Callback" % name
- if index is None:
- blink_entry = tag
- else:
- blink_entry = "_%s_%d_Callback" % (name, index)
+ blink_entry = tag
components = [interface_name, tag]
- if types is not None:
- components.extend(types)
native_entry = "_".join(components)
if not is_static and kind != 'Constructor':
args.insert(0, "mthis")

Powered by Google App Engine
This is Rietveld 408576698