Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 668603004: Remove InlineEditableItemList from tab order. (Closed)

Created:
6 years, 2 months ago by bondd
Modified:
6 years, 2 months ago
Reviewers:
*Dan Beam, hcarmona
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove InlineEditableItemList from tab order. Remove InlineEditableItemList (but not the InlineEditableItem items inside of it) from the tab order. Giving the list focus is useless, so skip it and go straight to focusing the first item. Improves "Manage search engines" dialog by making focus go directly to the first item in each list. Tested with all other InlineEditableItemList subclasses: autofill_options_list.js content_settings_exception_area.js browser_options_startup_page_list.js language_dictionary_overlay_world_list.js This change does not negatively impact any of these classes. Depends on https://codereview.chromium.org/666823003 to function properly. BUG=276874 Committed: https://crrev.com/4fc8dad0d6d9bf818e96ac19fbcad54373dd898e Cr-Commit-Position: refs/heads/master@{#300678}

Patch Set 1 #

Patch Set 2 : Get rid of accidentally-included file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/options/inline_editable_list.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
bondd
6 years, 2 months ago (2014-10-21 17:49:49 UTC) #3
Dan Beam
hcarmona@: are you OK with this approach? (you added the tabindex to lists themselves originally)
6 years, 2 months ago (2014-10-21 17:58:18 UTC) #5
hcarmona
On 2014/10/21 17:58:18, Dan Beam wrote: > hcarmona@: are you OK with this approach? (you ...
6 years, 2 months ago (2014-10-21 18:40:11 UTC) #6
Dan Beam
lgtm
6 years, 2 months ago (2014-10-21 19:04:26 UTC) #7
bondd
6 years, 2 months ago (2014-10-21 19:14:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668603004/20001
6 years, 2 months ago (2014-10-21 19:16:29 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/27785)
6 years, 2 months ago (2014-10-21 20:19:44 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668603004/20001
6 years, 2 months ago (2014-10-22 14:49:26 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-22 14:51:05 UTC) #21
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 14:51:48 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4fc8dad0d6d9bf818e96ac19fbcad54373dd898e
Cr-Commit-Position: refs/heads/master@{#300678}

Powered by Google App Engine
This is Rietveld 408576698