Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 666823003: Add 'X' button to 'Manage search engines' tab order. (Closed)

Created:
6 years, 2 months ago by bondd
Modified:
6 years, 2 months ago
Reviewers:
groby-ooo-7-16, *Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add 'X' button to 'Manage search engines' tab order. 'X' delete button is now part of the focus order in the 'Manage search engines' options page. BUG=276874 Committed: https://crrev.com/e0738528aa9effbaaf3d6d8850940f7ff126c24c Cr-Commit-Position: refs/heads/master@{#300528}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/options/search_engine_manager_engine_list.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bondd
Breaking issue 664583006 into more CLs, per dbeam@ request in review of that issue.
6 years, 2 months ago (2014-10-20 19:21:56 UTC) #3
Dan Beam
lgtm
6 years, 2 months ago (2014-10-20 20:20:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666823003/1
6 years, 2 months ago (2014-10-21 17:48:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 18:40:35 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 18:41:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0738528aa9effbaaf3d6d8850940f7ff126c24c
Cr-Commit-Position: refs/heads/master@{#300528}

Powered by Google App Engine
This is Rietveld 408576698