src/ia32/full-codegen-ia32.cc - Issue 6685119: [Arguments] Remove the arguments shadow symbol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/full-codegen-ia32.cc

Issue 6685119: [Arguments] Remove the arguments shadow symbol. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/arguments

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/full-codegen-ia32.cc

diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc

index cdc1ea8d3c9a22667e8a457239e2bdfeb0145579..98080bb028cdbb1fdc40a04b8a62d712653f5de2 100644

--- a/src/ia32/full-codegen-ia32.cc

+++ b/src/ia32/full-codegen-ia32.cc

@@ -1135,7 +1135,7 @@ void FullCodeGenerator::EmitVariableLoad(Variable* var) {

// Three cases: non-this global variables, lookup slots, and all other

// types of slots.

Slot* slot = var->AsSlot();

- ASSERT((var->is_global() && !var->is_this()) == (slot != NULL));

+ ASSERT((var->is_global() && !var->is_this()) == (slot == NULL));

Kevin Millikin (Chromium) 2011/03/21 13:46:27 This was a silly typo, only present on the ia32 pl

if (slot == NULL) {

Comment cmnt(masm_, "Global variable");

« no previous file with comments | « src/heap-profiler.h ('k') | src/objects.h » ('j') | no next file with comments »