Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: chrome/browser/ui/views/tabs/side_tab_strip.cc

Issue 6685069: Disambiguate OnMouseCaptureLost from OnMouseReleased, etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments, fix tests, cleanup, etc. Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/tabs/base_tab_strip.cc ('k') | ui/views/view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/tabs/side_tab_strip.cc
diff --git a/chrome/browser/ui/views/tabs/side_tab_strip.cc b/chrome/browser/ui/views/tabs/side_tab_strip.cc
index f82720fa6185885db8263d1b4f205b6d957a9c13..f7b2d5e78e07f883cf41e292ae9ffca9267a65e3 100644
--- a/chrome/browser/ui/views/tabs/side_tab_strip.cc
+++ b/chrome/browser/ui/views/tabs/side_tab_strip.cc
@@ -29,10 +29,10 @@ class SideTabNewTabButton : public SideTab {
public:
explicit SideTabNewTabButton(TabStripController* controller);
- virtual bool ShouldPaintHighlight() const { return false; }
- virtual bool IsSelected() const { return false; }
- bool OnMousePressed(const views::MouseEvent& event);
- void OnMouseReleased(const views::MouseEvent& event, bool canceled);
+ virtual bool ShouldPaintHighlight() const OVERRIDE { return false; }
+ virtual bool IsSelected() const OVERRIDE { return false; }
+ virtual bool OnMousePressed(const views::MouseEvent& event) OVERRIDE;
+ virtual void OnMouseReleased(const views::MouseEvent& event) OVERRIDE;
private:
TabStripController* controller_;
@@ -56,9 +56,8 @@ bool SideTabNewTabButton::OnMousePressed(const views::MouseEvent& event) {
return true;
}
-void SideTabNewTabButton::OnMouseReleased(const views::MouseEvent& event,
- bool canceled) {
- if (!canceled && event.IsOnlyLeftMouseButton() && HitTest(event.location()))
+void SideTabNewTabButton::OnMouseReleased(const views::MouseEvent& event) {
+ if (event.IsOnlyLeftMouseButton() && HitTest(event.location()))
controller_->CreateNewTab();
}
« no previous file with comments | « chrome/browser/ui/views/tabs/base_tab_strip.cc ('k') | ui/views/view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698