chrome/browser/ui/views/tabs/base_tab_strip.cc - Issue 6685069: Disambiguate OnMouseCaptureLost from OnMouseReleased, etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/base_tab_strip.cc

Issue 6685069: Disambiguate OnMouseCaptureLost from OnMouseReleased, etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments, fix tests, cleanup, etc. Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/tabs/base_tab_strip.cc

diff --git a/chrome/browser/ui/views/tabs/base_tab_strip.cc b/chrome/browser/ui/views/tabs/base_tab_strip.cc

index b86b14de6551e9912f55019f8e79b18e004ff4f9..fba2c23b45861d6349c499da0469c68117f2c933 100644

--- a/chrome/browser/ui/views/tabs/base_tab_strip.cc

+++ b/chrome/browser/ui/views/tabs/base_tab_strip.cc

@@ -407,9 +407,12 @@ bool BaseTabStrip::OnMouseDragged(const views::MouseEvent& event) {

return true;

}

-void BaseTabStrip::OnMouseReleased(const views::MouseEvent& event,

- bool canceled) {

- EndDrag(canceled);

+void BaseTabStrip::OnMouseReleased(const views::MouseEvent& event) {

+ EndDrag(false);

+void BaseTabStrip::OnMouseCaptureLost() {

+ EndDrag(true);

}

void BaseTabStrip::StartMoveTabAnimation() {