Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 6685068: Add VbSharedData field parsing (Closed)

Created:
9 years, 9 months ago by Randall Spangler
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

Add VbSharedData field parsing R=reinauer@chromium.org BUG=chrome-os-partner:2578 TEST=manual crossystem vdat_timers should show 'LFS=0,0 LF=number1,number2 LK=number3,number4' where number1 < number2 < number3 < number4 crossystem vdat_lfdebug run from a dev mode console, should show 'check=12,0 index=0x00 tpmver=(hex number) lowestver=(hex number)' crossystem vdat_flags run from a dev mode console, flags should be 0x04. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=f4ba19d

Patch Set 1 #

Patch Set 2 : Print flags as hex #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -96 lines) Patch
M firmware/include/load_firmware_fw.h View 2 chunks +12 lines, -10 lines 0 comments Download
M firmware/include/vboot_struct.h View 3 chunks +38 lines, -2 lines 0 comments Download
M firmware/lib/vboot_common.c View 3 chunks +8 lines, -0 lines 0 comments Download
M firmware/lib/vboot_firmware.c View 15 chunks +25 lines, -1 line 0 comments Download
M firmware/stub/load_firmware_stub.c View 1 chunk +2 lines, -2 lines 0 comments Download
M host/lib/crossystem.c View 7 chunks +92 lines, -40 lines 0 comments Download
M utility/crossystem_main.c View 1 7 chunks +46 lines, -39 lines 0 comments Download
M utility/load_kernel_test.c View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Randall Spangler
9 years, 9 months ago (2011-03-17 21:01:25 UTC) #1
Stefan Reinauer
9 years, 9 months ago (2011-03-17 22:46:23 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698