Make channel available in Java via ChromeVersionConstants.java.

Make channel available in Java via ChromeVersionConstants.java.

Channel information is now available statically at build time. There's
no need to call ChromeVersionInfo.init() anymore.

Committed: https://crrev.com/b5753f5c3bcbd9871f81537c258c2ac699affef8
Cr-Commit-Position: refs/heads/master@{#301952}

[newt (away), 2014-10-23 17:41:43]

newt@chromium.org changed reviewers:
+ cjhopman@chromium.org

[newt (away), 2014-10-23 17:41:44]

PTAL

[cjhopman, 2014-10-23 18:46:41]

lgtm

https://codereview.chromium.org/668343004/diff/1/chrome/chrome_android.gypi
File chrome/chrome_android.gypi (right):

https://codereview.chromium.org/668343004/diff/1/chrome/chrome_android.gypi#n...
chrome/chrome_android.gypi:103: '-e', 'CHANNEL=str.upper("<(android_channel)")',
The str.upper is processed by jinja? That's great.

[newt (away), 2014-10-23 19:05:05]

On 2014/10/23 18:46:41, cjhopman wrote:
> lgtm
> 
> https://codereview.chromium.org/668343004/diff/1/chrome/chrome_android.gypi
> File chrome/chrome_android.gypi (right):
> 
>
https://codereview.chromium.org/668343004/diff/1/chrome/chrome_android.gypi#n...
> chrome/chrome_android.gypi:103: '-e',
'CHANNEL=str.upper("<(android_channel)")',
> The str.upper is processed by jinja? That's great.

Actually, version.py does that magic :)

[newt (away), 2014-10-23 19:05:52]

newt@chromium.org changed reviewers:
+ yfriedmanc@chromium.org

[newt (away), 2014-10-23 19:05:53]

yfriedman for OWNERS approval

[cjhopman, 2014-10-23 20:46:36]

https://codereview.chromium.org/668343004/diff/1/chrome/chrome_android.gypi
File chrome/chrome_android.gypi (right):

https://codereview.chromium.org/668343004/diff/1/chrome/chrome_android.gypi#n...
chrome/chrome_android.gypi:103: '-e', 'CHANNEL=str.upper("<(android_channel)")',
On 2014/10/23 18:46:41, cjhopman wrote:
> The str.upper is processed by jinja? That's great.
Right.

[newt (away), 2014-10-23 20:55:00]

newt@chromium.org changed reviewers:
+ yfriedman@chromium.org
- yfriedmanc@chromium.org

[newt (away), 2014-10-23 20:55:00]

+the right yfriedman for OWNERS

[newt (away), 2014-10-23 21:31:17]

newt@chromium.org changed reviewers:
+ brettw@chromium.org

[newt (away), 2014-10-23 21:31:17]

brettw: chrome/version.gni

[cjhopman, 2014-10-23 21:42:05]

https://codereview.chromium.org/668343004/diff/20001/chrome/android/channel.gni
File chrome/android/channel.gni (right):

https://codereview.chromium.org/668343004/diff/20001/chrome/android/channel.g...
chrome/android/channel.gni:9: }
Could assert that the androdi_channel is one of the valid options here. Not sure
if that's useful or not.

https://codereview.chromium.org/668343004/diff/20001/chrome/version.gni
File chrome/version.gni (right):

https://codereview.chromium.org/668343004/diff/20001/chrome/version.gni#newco...
chrome/version.gni:43: extra_args = []
document this new parameter above.

https://codereview.chromium.org/668343004/diff/20001/chrome/version.gni#newco...
chrome/version.gni:43: extra_args = []
Also, I think my preference would be to expose a less powerful thing. Maybe
eval_args or some such (to match how it's described in build/util/version.py
--help) and do:

if (defined(invoker.eval_args)) {
  foreach(eval, invoker.eval_args) {
    args += [ "-e", eval ]
  }
}

[Yaron, 2014-10-23 21:58:00]

lgtm

[newt (away), 2014-10-23 21:58:16]

The CQ bit was checked by newt@chromium.org

[newt (away), 2014-10-23 21:58:17]

The CQ bit was unchecked by newt@chromium.org

[newt (away), 2014-10-23 22:02:28]

https://codereview.chromium.org/668343004/diff/20001/chrome/version.gni
File chrome/version.gni (right):

https://codereview.chromium.org/668343004/diff/20001/chrome/version.gni#newco...
chrome/version.gni:43: extra_args = []
On 2014/10/23 21:42:05, cjhopman wrote:
> Also, I think my preference would be to expose a less powerful thing. Maybe
> eval_args or some such (to match how it's described in build/util/version.py
> --help) and do:
> 
> if (defined(invoker.eval_args)) {
>   foreach(eval, invoker.eval_args) {
>     args += [ "-e", eval ]
>   }
> }

I considered that, but it didn't really seem worth duplicating the entire
interface of version.py into version.gni. It's more code duplication with
minimal benefits in my view. WDYT?

[cjhopman, 2014-10-23 22:05:48]

https://codereview.chromium.org/668343004/diff/20001/chrome/version.gni
File chrome/version.gni (right):

https://codereview.chromium.org/668343004/diff/20001/chrome/version.gni#newco...
chrome/version.gni:43: extra_args = []
On 2014/10/23 22:02:28, newt wrote:
> On 2014/10/23 21:42:05, cjhopman wrote:
> > Also, I think my preference would be to expose a less powerful thing. Maybe
> > eval_args or some such (to match how it's described in build/util/version.py
> > --help) and do:
> > 
> > if (defined(invoker.eval_args)) {
> >   foreach(eval, invoker.eval_args) {
> >     args += [ "-e", eval ]
> >   }
> > }
> 
> I considered that, but it didn't really seem worth duplicating the entire
> interface of version.py into version.gni. It's more code duplication with
> minimal benefits in my view. WDYT?

sgtm

[newt (away), 2014-10-23 22:25:24]

https://codereview.chromium.org/668343004/diff/20001/chrome/android/channel.gni
File chrome/android/channel.gni (right):

https://codereview.chromium.org/668343004/diff/20001/chrome/android/channel.g...
chrome/android/channel.gni:9: }
On 2014/10/23 21:42:05, cjhopman wrote:
> Could assert that the androdi_channel is one of the valid options here. Not
sure
> if that's useful or not.

Done.

https://codereview.chromium.org/668343004/diff/20001/chrome/version.gni
File chrome/version.gni (right):

https://codereview.chromium.org/668343004/diff/20001/chrome/version.gni#newco...
chrome/version.gni:43: extra_args = []
On 2014/10/23 21:42:05, cjhopman wrote:
> document this new parameter above.

Done.

[newt (away), 2014-10-27 17:37:46]

brettw: ping for chrome/version.gni

[newt (away), 2014-10-29 03:27:51]

brettw: PTAL at chrome/version.gni

[brettw, 2014-10-29 20:46:36]

lgtm

https://codereview.chromium.org/668343004/diff/40001/chrome/version.gni
File chrome/version.gni (right):

https://codereview.chromium.org/668343004/diff/40001/chrome/version.gni#newco...
chrome/version.gni:67: ] + extra_args
I'd just move the if down below here and avoid the local temporary. So

if (defined(invoker.extra_args)) {
  args += extra_args
}

[newt (away), 2014-10-29 21:04:19]

https://codereview.chromium.org/668343004/diff/40001/chrome/version.gni
File chrome/version.gni (right):

https://codereview.chromium.org/668343004/diff/40001/chrome/version.gni#newco...
chrome/version.gni:67: ] + extra_args
On 2014/10/29 20:46:36, brettw wrote:
> I'd just move the if down below here and avoid the local temporary. So
> 
> if (defined(invoker.extra_args)) {
>   args += extra_args
> }

Good point. Done.

[newt (away), 2014-10-29 21:04:29]

The CQ bit was checked by newt@chromium.org

[commit-bot: I haz the power, 2014-10-29 21:06:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/668343004/60001

[commit-bot: I haz the power, 2014-10-29 22:24:34]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-10-29 22:25:16]

Patchset 4 (id:??) landed as
https://crrev.com/b5753f5c3bcbd9871f81537c258c2ac699affef8
Cr-Commit-Position: refs/heads/master@{#301952}