Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Side by Side Diff: chrome/version.gni

Issue 668343004: Make channel available in Java via ChromeVersionConstants.java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: brettw's comment Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/chrome_android.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Runs the version processing script over the given template file to produce 5 # Runs the version processing script over the given template file to produce
6 # an output file. This is used for generating various forms of files that 6 # an output file. This is used for generating various forms of files that
7 # incorporate the product name and version. 7 # incorporate the product name and version.
8 # 8 #
9 # This template automatically includes VERSION, LASTCHANGE, and BRANDING, 9 # This template automatically includes VERSION, LASTCHANGE, and BRANDING,
10 # 10 #
11 # Parameters: 11 # Parameters:
12 # source: 12 # source:
13 # File name of source template file to read. 13 # File name of source template file to read.
14 # 14 #
15 # output: 15 # output:
16 # File name of file to write. 16 # File name of file to write.
17 # 17 #
18 # extra_args:
19 # Extra arguments to pass to version.py.
20 #
18 # visibility (optional) 21 # visibility (optional)
19 # 22 #
20 # Example: 23 # Example:
21 # process_version("myversion") { 24 # process_version("myversion") {
22 # source = "myfile.h.in" 25 # source = "myfile.h.in"
23 # output = "$target_gen_dir/myfile.h" 26 # output = "$target_gen_dir/myfile.h"
27 # extra_args = ["-e", "FOO=42"]
24 # } 28 # }
25 template("process_version") { 29 template("process_version") {
26 assert(defined(invoker.source), "Source must be defined for $target_name") 30 assert(defined(invoker.source), "Source must be defined for $target_name")
27 assert(defined(invoker.output), "Output must be defined for $target_name") 31 assert(defined(invoker.output), "Output must be defined for $target_name")
28 32
29 action(target_name) { 33 action(target_name) {
30 if (defined(invoker.visibility)) { 34 if (defined(invoker.visibility)) {
31 visibility = invoker.visibility 35 visibility = invoker.visibility
32 } 36 }
33 script = "//build/util/version.py" 37 script = "//build/util/version.py"
(...skipping 12 matching lines...) Expand all
46 lastchange_path, 50 lastchange_path,
47 branding_path, 51 branding_path,
48 ] 52 ]
49 53
50 outputs = [ invoker.output ] 54 outputs = [ invoker.output ]
51 55
52 args = [ 56 args = [
53 "-f", rebase_path(version_path, root_build_dir), 57 "-f", rebase_path(version_path, root_build_dir),
54 "-f", rebase_path(branding_path, root_build_dir), 58 "-f", rebase_path(branding_path, root_build_dir),
55 "-f", rebase_path(lastchange_path, root_build_dir), 59 "-f", rebase_path(lastchange_path, root_build_dir),
56 rebase_path(invoker.source, root_build_dir), 60 "-i", rebase_path(invoker.source, root_build_dir),
57 rebase_path(invoker.output, root_build_dir), 61 "-o", rebase_path(invoker.output, root_build_dir),
58 ] 62 ]
63
64 if (defined(invoker.extra_args)) {
65 args += invoker.extra_args
66 }
59 } 67 }
60 } 68 }
OLDNEW
« no previous file with comments | « chrome/chrome_android.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698