Reject JWK key import when key_ops contains duplicate values.

Reject JWK key import when key_ops contains duplicate values.

BUG=378074
Committed: https://crrev.com/ca92d1ea76a9dbfa969459a1f58894c38e586051
Cr-Commit-Position: refs/heads/master@{#301536}

[eroman, 2014-10-22 21:56:53]

Patchset #1 (id:1) has been deleted

[eroman, 2014-10-22 21:57:43]

eroman@chromium.org changed reviewers:
+ rsleevi@chromium.org

[Ryan Sleevi, 2014-10-27 22:19:36]

lgtm

https://codereview.chromium.org/668313002/diff/20001/content/child/webcrypto/...
File content/child/webcrypto/webcrypto_util.cc (right):

https://codereview.chromium.org/668313002/diff/20001/content/child/webcrypto/...
content/child/webcrypto/webcrypto_util.cc:82: scoped_ptr<std::set<std::string>>
unrecognized_usages;
This seems to be premature optimization. Are you sure the heap allocation
overhead is less than the initialization cost?

[eroman, 2014-10-27 23:29:04]

https://codereview.chromium.org/668313002/diff/20001/content/child/webcrypto/...
File content/child/webcrypto/webcrypto_util.cc (right):

https://codereview.chromium.org/668313002/diff/20001/content/child/webcrypto/...
content/child/webcrypto/webcrypto_util.cc:82: scoped_ptr<std::set<std::string>>
unrecognized_usages;
On 2014/10/27 22:19:36, Ryan Sleevi wrote:
> This seems to be premature optimization. Are you sure the heap allocation
> overhead is less than the initialization cost?

Removed in favor of stack allocation.

Agreed. I did some performance tests and the impact was irrelevant.

[eroman, 2014-10-27 23:29:07]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-10-27 23:30:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/668313002/40001

[commit-bot: I haz the power, 2014-10-28 01:15:29]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2014-10-28 01:16:10]

Patchset 2 (id:??) landed as
https://crrev.com/ca92d1ea76a9dbfa969459a1f58894c38e586051
Cr-Commit-Position: refs/heads/master@{#301536}