content/child/webcrypto/webcrypto_util.h - Issue 668313002: Reject JWK key import when key_ops contains duplicate values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/webcrypto/webcrypto_util.h

Issue 668313002: Reject JWK key import when key_ops contains duplicate values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove heap-allocated std::set Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/child/webcrypto/webcrypto_util.h

diff --git a/content/child/webcrypto/webcrypto_util.h b/content/child/webcrypto/webcrypto_util.h

index af8c8e91eff4dad354796a3faeea991b5967cf86..26b4675f059cf5582cc2eb979e095de8d616ad71 100644

--- a/content/child/webcrypto/webcrypto_util.h

+++ b/content/child/webcrypto/webcrypto_util.h

@@ -19,10 +19,10 @@ namespace webcrypto {

class Status;

-// Composes a Web Crypto usage mask from an array of JWK key_ops values.

-CONTENT_EXPORT Status GetWebCryptoUsagesFromJwkKeyOps(

- const base::ListValue* jwk_key_ops_value,

- blink::WebCryptoKeyUsageMask* jwk_key_ops_mask);

+// Converts a JWK "key_ops" array to the corresponding WebCrypto usages.

+CONTENT_EXPORT Status

+ GetWebCryptoUsagesFromJwkKeyOps(const base::ListValue* key_ops,

+ blink::WebCryptoKeyUsageMask* usages);

// Composes a JWK key_ops array from a Web Crypto usage mask.

base::ListValue* CreateJwkKeyOpsFromWebCryptoUsages(

« no previous file with comments | « content/child/webcrypto/test/aes_cbc_unittest.cc ('k') | content/child/webcrypto/webcrypto_util.cc » ('j') | no next file with comments »