Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 668163002: Enabled the App Info dialog on the Extensions page by default (Closed)

Created:
6 years, 2 months ago by sashab
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enabled the App Info dialog on the Extensions page by default Changed the flag '--enable-extension-info-dialog' to '--disable-extension-info-dialog', which enables the App Info dialog as the default dialog for displaying permissions on the extensions page. Does not affect Mac platforms (where the old-style dialog is still used). BUG=395495 Committed: https://crrev.com/a867ca2b5e42207b65e9d07702138ff79bed0bb0 Cr-Commit-Position: refs/heads/master@{#301006} Committed: https://crrev.com/11778438dcb7670324f52e5df111e4007b9224ac Cr-Commit-Position: refs/heads/master@{#301046}

Patch Set 1 #

Patch Set 2 : Fixed small namespace error #

Total comments: 1

Patch Set 3 : Small namespace fix #

Patch Set 4 : Histograms file fix #

Total comments: 2

Patch Set 5 : Review feedback #

Total comments: 2

Patch Set 6 : Added histogram back #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -23 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 2 3 4 3 chunks +15 lines, -4 lines 0 comments Download
M extensions/common/switches.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/switches.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (5 generated)
sashab
benwells@chromium.org: Please review changes in extensions/* thestig@chromium.org: Please review changes in chrome/*
6 years, 2 months ago (2014-10-22 09:33:05 UTC) #2
Lei Zhang
chrome/ lgtm https://codereview.chromium.org/668163002/diff/20001/chrome/browser/ui/webui/extensions/extension_settings_handler.cc File chrome/browser/ui/webui/extensions/extension_settings_handler.cc (right): https://codereview.chromium.org/668163002/diff/20001/chrome/browser/ui/webui/extensions/extension_settings_handler.cc#newcode120 chrome/browser/ui/webui/extensions/extension_settings_handler.cc:120: display_extension_info_dialog = !CommandLine::ForCurrentProcess()->HasSwitch( nit: base::CommandLine
6 years, 2 months ago (2014-10-22 20:03:40 UTC) #3
sashab
asvitkine@chromium.org: Please review changes in histograms.xml :)
6 years, 2 months ago (2014-10-23 00:35:48 UTC) #5
benwells
lgtm with a nit https://codereview.chromium.org/668163002/diff/60001/chrome/browser/ui/webui/extensions/extension_settings_handler.cc File chrome/browser/ui/webui/extensions/extension_settings_handler.cc (right): https://codereview.chromium.org/668163002/diff/60001/chrome/browser/ui/webui/extensions/extension_settings_handler.cc#newcode118 chrome/browser/ui/webui/extensions/extension_settings_handler.cc:118: bool display_extension_info_dialog = false; super ...
6 years, 2 months ago (2014-10-23 00:43:16 UTC) #6
sashab
https://codereview.chromium.org/668163002/diff/60001/chrome/browser/ui/webui/extensions/extension_settings_handler.cc File chrome/browser/ui/webui/extensions/extension_settings_handler.cc (right): https://codereview.chromium.org/668163002/diff/60001/chrome/browser/ui/webui/extensions/extension_settings_handler.cc#newcode118 chrome/browser/ui/webui/extensions/extension_settings_handler.cc:118: bool display_extension_info_dialog = false; On 2014/10/23 00:43:16, benwells wrote: ...
6 years, 2 months ago (2014-10-23 06:34:36 UTC) #7
Alexei Svitkine (slow)
https://codereview.chromium.org/668163002/diff/80001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/668163002/diff/80001/tools/metrics/histograms/histograms.xml#oldcode46196 tools/metrics/histograms/histograms.xml:46196: - <int value="-1938263248" label="enable-extension-info-dialog"/> Please keep the existing value ...
6 years, 2 months ago (2014-10-23 15:25:33 UTC) #8
sashab
https://codereview.chromium.org/668163002/diff/80001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/668163002/diff/80001/tools/metrics/histograms/histograms.xml#oldcode46196 tools/metrics/histograms/histograms.xml:46196: - <int value="-1938263248" label="enable-extension-info-dialog"/> On 2014/10/23 15:25:33, Alexei Svitkine ...
6 years, 2 months ago (2014-10-23 22:42:58 UTC) #9
Mark P
histograms.xml lgtm
6 years, 2 months ago (2014-10-23 22:52:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668163002/100001
6 years, 2 months ago (2014-10-23 23:12:56 UTC) #13
commit-bot: I haz the power
Committed patchset #6 (id:100001)
6 years, 2 months ago (2014-10-24 00:43:00 UTC) #14
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/a867ca2b5e42207b65e9d07702138ff79bed0bb0 Cr-Commit-Position: refs/heads/master@{#301006}
6 years, 2 months ago (2014-10-24 00:43:43 UTC) #15
kochi
On 2014/10/24 00:43:43, I haz the power (commit-bot) wrote: > Patchset 6 (id:??) landed as ...
6 years, 2 months ago (2014-10-24 02:14:26 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668163002/100001
6 years, 2 months ago (2014-10-24 04:04:49 UTC) #18
commit-bot: I haz the power
Committed patchset #6 (id:100001)
6 years, 2 months ago (2014-10-24 04:05:33 UTC) #19
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 04:06:10 UTC) #20
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/11778438dcb7670324f52e5df111e4007b9224ac
Cr-Commit-Position: refs/heads/master@{#301046}

Powered by Google App Engine
This is Rietveld 408576698