Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc |
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc |
index a2972ec3fa83eb036e95fa4a744e9e92e4273dc9..3fa32863352ab12bcf3995119694bcdb45a8efc9 100644 |
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc |
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc |
@@ -108,10 +108,23 @@ using content::RenderViewHost; |
using content::WebContents; |
namespace { |
+ |
const char kAppsDeveloperToolsExtensionId[] = |
"ohmmkhmmmpcnpikjeljgnaoabkaalbgc"; |
+ |
+// Returns true if the extensions page should display the new-style extension |
+// info dialog. If false, display the old permissions dialog. |
+bool ShouldDisplayExtensionInfoDialog() { |
+#if defined(OS_MACOSX) |
+ return false; |
+#else |
+ return !base::CommandLine::ForCurrentProcess()->HasSwitch( |
+ extensions::switches::kDisableExtensionInfoDialog); |
+#endif |
} |
+} // namespace |
+ |
namespace extensions { |
ExtensionPage::ExtensionPage(const GURL& url, |
@@ -537,8 +550,7 @@ void ExtensionSettingsHandler::GetLocalizedValues( |
l10n_util::GetStringUTF16(IDS_EXTENSIONS_RELOAD_UNPACKED)); |
source->AddString("extensionSettingsOptions", |
l10n_util::GetStringUTF16(IDS_EXTENSIONS_OPTIONS_LINK)); |
- if (CommandLine::ForCurrentProcess()->HasSwitch( |
- switches::kEnableExtensionInfoDialog)) { |
+ if (ShouldDisplayExtensionInfoDialog()) { |
source->AddString("extensionSettingsPermissions", |
l10n_util::GetStringUTF16(IDS_EXTENSIONS_INFO_LINK)); |
} else { |
@@ -1199,8 +1211,7 @@ void ExtensionSettingsHandler::HandlePermissionsMessage( |
// Show the new-style extensions dialog when the flag is set. The flag cannot |
// be set on Mac platforms. |
- if (CommandLine::ForCurrentProcess()->HasSwitch( |
- switches::kEnableExtensionInfoDialog)) { |
+ if (ShouldDisplayExtensionInfoDialog()) { |
UMA_HISTOGRAM_ENUMERATION("Apps.AppInfoDialog.Launches", |
AppInfoLaunchSource::FROM_EXTENSIONS_PAGE, |
AppInfoLaunchSource::NUM_LAUNCH_SOURCES); |