chrome/browser/printing/print_job_worker.cc - Issue 668093002: Standardize usage of virtual/override/final in chrome/browser/printing/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_job_worker.cc

Issue 668093002: Standardize usage of virtual/override/final in chrome/browser/printing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/print_job_unittest.cc ('k') | chrome/browser/printing/print_preview_context_menu_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/print_job_worker.cc

diff --git a/chrome/browser/printing/print_job_worker.cc b/chrome/browser/printing/print_job_worker.cc

index 2313d6ace60757089474cf7cf36c8dbeb85071df..ee8cddea181a9a759182b4d828a3d4a45ae424da 100644

--- a/chrome/browser/printing/print_job_worker.cc

+++ b/chrome/browser/printing/print_job_worker.cc

@@ -39,10 +39,10 @@ void HoldRefCallback(const scoped_refptr<printing::PrintJobWorkerOwner>& owner,

class PrintingContextDelegate : public PrintingContext::Delegate {

public:

PrintingContextDelegate(int render_process_id, int render_view_id);

- virtual ~PrintingContextDelegate();

+ ~PrintingContextDelegate() override;

- virtual gfx::NativeView GetParentView() override;

- virtual std::string GetAppLocale() override;

+ gfx::NativeView GetParentView() override;

+ std::string GetAppLocale() override;

private:

int render_process_id_;

« no previous file with comments | « chrome/browser/printing/print_job_unittest.cc ('k') | chrome/browser/printing/print_preview_context_menu_observer.h » ('j') | no next file with comments »