Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: chrome/browser/printing/print_job_unittest.cc

Issue 668093002: Standardize usage of virtual/override/final in chrome/browser/printing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/printing/print_job_manager.h ('k') | chrome/browser/printing/print_job_worker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/print_job_unittest.cc
diff --git a/chrome/browser/printing/print_job_unittest.cc b/chrome/browser/printing/print_job_unittest.cc
index 118c4b188f688cc6e24a417b7b23e279cbc64080..b51468264c7dd77d2a1e57d8c0d2035363dc228c 100644
--- a/chrome/browser/printing/print_job_unittest.cc
+++ b/chrome/browser/printing/print_job_unittest.cc
@@ -19,9 +19,7 @@ namespace {
class TestSource : public printing::PrintedPagesSource {
public:
- virtual base::string16 RenderSourceName() override {
- return base::string16();
- }
+ base::string16 RenderSourceName() override { return base::string16(); }
};
class TestPrintJobWorker : public printing::PrintJobWorker {
@@ -35,12 +33,11 @@ class TestPrintJobWorker : public printing::PrintJobWorker {
class TestOwner : public printing::PrintJobWorkerOwner {
public:
- virtual void GetSettingsDone(
- const printing::PrintSettings& new_settings,
- printing::PrintingContext::Result result) override {
+ void GetSettingsDone(const printing::PrintSettings& new_settings,
+ printing::PrintingContext::Result result) override {
EXPECT_FALSE(true);
}
- virtual printing::PrintJobWorker* DetachWorker(
+ printing::PrintJobWorker* DetachWorker(
printing::PrintJobWorkerOwner* new_owner) override {
// We're screwing up here since we're calling worker from the main thread.
// That's fine for testing. It is actually simulating PrinterQuery behavior.
@@ -50,15 +47,11 @@ class TestOwner : public printing::PrintJobWorkerOwner {
settings_ = worker->printing_context()->settings();
return worker;
}
- virtual const printing::PrintSettings& settings() const override {
- return settings_;
- }
- virtual int cookie() const override {
- return 42;
- }
+ const printing::PrintSettings& settings() const override { return settings_; }
+ int cookie() const override { return 42; }
private:
- virtual ~TestOwner() {}
+ ~TestOwner() override {}
printing::PrintSettings settings_;
};
@@ -68,18 +61,16 @@ class TestPrintJob : public printing::PrintJob {
explicit TestPrintJob(volatile bool* check) : check_(check) {
}
private:
- virtual ~TestPrintJob() {
- *check_ = true;
- }
+ ~TestPrintJob() override { *check_ = true; }
volatile bool* check_;
};
class TestPrintNotifObserv : public content::NotificationObserver {
public:
// content::NotificationObserver
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) override {
+ void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) override {
ADD_FAILURE();
}
};
« no previous file with comments | « chrome/browser/printing/print_job_manager.h ('k') | chrome/browser/printing/print_job_worker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698