chrome/browser/printing/print_dialog_cloud.cc - Issue 668093002: Standardize usage of virtual/override/final in chrome/browser/printing/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_dialog_cloud.cc

Issue 668093002: Standardize usage of virtual/override/final in chrome/browser/printing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc ('k') | chrome/browser/printing/print_dialog_cloud_internal.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/print_dialog_cloud.cc

diff --git a/chrome/browser/printing/print_dialog_cloud.cc b/chrome/browser/printing/print_dialog_cloud.cc

index 5aa77aeb7c564e287283cea94a8c6b5686634327..b5d49f07ae9c2014d2280b3034343525c9de5e87 100644

--- a/chrome/browser/printing/print_dialog_cloud.cc

+++ b/chrome/browser/printing/print_dialog_cloud.cc

@@ -143,7 +143,7 @@ class SignInObserver : public content::WebContentsObserver {

private:

// Overridden from content::WebContentsObserver:

- virtual void DidNavigateMainFrame(

+ void DidNavigateMainFrame(

const content::LoadCommittedDetails& details,

const content::FrameNavigateParams& params) override {

if (IsSimilarUrl(params.url, cloud_print_url_)) {

@@ -154,9 +154,7 @@ class SignInObserver : public content::WebContentsObserver {

}

- virtual void WebContentsDestroyed() override {

- delete this;

- }

+ void WebContentsDestroyed() override { delete this; }

void OnSignIn() {

callback_.Run();