Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2429)

Unified Diff: chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc

Issue 668093002: Standardize usage of virtual/override/final in chrome/browser/printing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc
diff --git a/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc b/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc
index 1ffdd53beecf69bc8aa0475b796f344a683feb9e..c3bfbebfd1d4311e2197b750bd6116cd3286d395 100644
--- a/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc
+++ b/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc
@@ -89,9 +89,7 @@ void ShutdownTask() {
class TestStartupClientChannelListener : public IPC::Listener {
public:
- virtual bool OnMessageReceived(const IPC::Message& message) override {
- return false;
- }
+ bool OnMessageReceived(const IPC::Message& message) override { return false; }
};
} // namespace
@@ -99,7 +97,7 @@ class TestStartupClientChannelListener : public IPC::Listener {
class TestServiceProcess : public ServiceProcess {
public:
TestServiceProcess() { }
- virtual ~TestServiceProcess() { }
+ ~TestServiceProcess() override {}
bool Initialize(base::MessageLoopForUI* message_loop,
ServiceProcessState* state);
@@ -316,13 +314,11 @@ class CloudPrintProxyPolicyStartupTest : public base::MultiProcessTest,
void ShutdownAndWaitForExitWithTimeout(base::ProcessHandle handle);
// IPC::Listener implementation
- virtual bool OnMessageReceived(const IPC::Message& message) override {
- return false;
- }
- virtual void OnChannelConnected(int32 peer_pid) override;
+ bool OnMessageReceived(const IPC::Message& message) override { return false; }
+ void OnChannelConnected(int32 peer_pid) override;
// MultiProcessTest implementation.
- virtual CommandLine MakeCmdLine(const std::string& procname) override;
+ CommandLine MakeCmdLine(const std::string& procname) override;
bool LaunchBrowser(const CommandLine& command_line, Profile* profile) {
int return_code = 0;

Powered by Google App Engine
This is Rietveld 408576698